[PR #7940] [MERGED] chore: code cleanup #8227

New issue

Closed

opened 2026-03-23 23:23:12 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7940
Author: @richardshiue
Created: 5/16/2025
Status: ✅ Merged
Merged: 5/16/2025
Merged by: @richardshiue

Base: main ← Head: chore/code-cleanup

📝 Commits (1)

6a84ed3 chore: code cleanup

📊 Changes

1 file changed (+112 additions, -119 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_menu.dart (+112 -119)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Refactor the SettingsMenu widget to simplify its layout and styling

Enhancements:

Replace Expanded and DecoratedBox wrappers with a single Container that directly applies height, decoration, and padding
Use Column.spacing property and theme.spacing constants in place of SeparatedColumn and manual VSpace separators
Simplify border radius definition with BorderRadiusDirectional.horizontal and unify scroll view setup with consistent physics and padding

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7940 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 5/16/2025 **Status:** ✅ Merged **Merged:** 5/16/2025 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `chore/code-cleanup` --- ### 📝 Commits (1) - [`6a84ed3`](https://github.com/AppFlowy-IO/AppFlowy/commit/6a84ed30e576318ed3eba33a3d2b036a7abdbf5d) chore: code cleanup ### 📊 Changes **1 file changed** (+112 additions, -119 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_menu.dart` (+112 -119) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. ## Summary by Sourcery Refactor the SettingsMenu widget to simplify its layout and styling Enhancements: - Replace Expanded and DecoratedBox wrappers with a single Container that directly applies height, decoration, and padding - Use Column.spacing property and theme.spacing constants in place of SeparatedColumn and manual VSpace separators - Simplify border radius definition with BorderRadiusDirectional.horizontal and unify scroll view setup with consistent physics and padding --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>