AppFlowy-IO/AppFlowy

Fork

You've already forked AppFlowy

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 21:00:19 +00:00

Code Issues 1.9k Projects Packages Wiki Activity

[PR #7957] [MERGED] feat: optimize shared section logic #8236

New issue

Closed

opened 2026-03-23 23:23:14 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:14 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7957
Author: @LucasXu0
Created: 5/20/2025
Status: ✅ Merged
Merged: 5/21/2025
Merged by: @LucasXu0

Base: main ← Head: share_section

📝 Commits (10+)

246b2f3 chore: bump AppFlowy version to 1.0.0 and add sharedSection feature flag
bbe1797 feat: conditionally display spaces in sidebar based on user role
8ebbc4b refactor: update user avatar implementation and enhance shared section functionality
53319fd fix: typo
5e37553 refactor: enhance share tab functionality and error handling
0f09cd4 chore: i18n
2e0b802 feat: turn guest into member
ed2e2e7 fix: unit tests
da0b096 fix: unit tests
97e5d0e chore: revert version changes

📊 Changes

45 files changed (+281 additions, -209 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/features/share_tab/data/models/share_access_level.dart (+7 -4)
📝 frontend/appflowy_flutter/lib/features/share_tab/data/models/shared_user.dart (+16 -0)
📝 frontend/appflowy_flutter/lib/features/share_tab/data/repositories/local_share_with_user_repository.dart (+14 -0)
📝 frontend/appflowy_flutter/lib/features/share_tab/data/repositories/rust_share_with_user_repository.dart (+29 -1)
📝 frontend/appflowy_flutter/lib/features/share_tab/data/repositories/share_with_user_repository.dart (+8 -2)
📝 frontend/appflowy_flutter/lib/features/share_tab/presentation/share_tab.dart (+34 -13)
📝 frontend/appflowy_flutter/lib/features/share_tab/presentation/widgets/access_level_list_widget.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/features/share_tab/presentation/widgets/copy_link_widget.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/features/share_tab/presentation/widgets/people_with_access_section.dart (+5 -5)
📝 frontend/appflowy_flutter/lib/features/share_tab/presentation/widgets/share_with_user_widget.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/features/share_tab/presentation/widgets/shared_group_widget.dart (+10 -5)
📝 frontend/appflowy_flutter/lib/features/share_tab/presentation/widgets/shared_user_widget.dart (+11 -7)
📝 frontend/appflowy_flutter/lib/features/shared_section/data/rust_share_pagers_repository.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/features/shared_section/logic/shared_section_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/features/shared_section/presentation/shared_section.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/features/shared_section/presentation/widgets/refresh_button.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/features/shared_section/presentation/widgets/shared_pages_list.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/features/shared_section/presentation/widgets/shared_section_header.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/features/util/extensions.dart (+27 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/workspace/add_members_screen.dart (+1 -1)

...and 25 more files

📄 Description

Feature Preview

bump AppFlowy version to 1.0.0 and add sharedSection feature flag
conditionally display spaces in sidebar based on user role
update user avatar implementation and enhance shared sectio…
typo
enhance share tab functionality and error handling
i18n

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Optimize and enhance shared section and sharing UI by introducing a feature flag, refining sidebar visibility, unifying avatar components, bolstering error handling, and adding internationalization.

New Features:

Introduce sharedSection feature flag with polling support
Conditionally display shared section and spaces in sidebar based on user role

Bug Fixes:

Correct typos in invitation import paths and sidebar upgrade button name
Fix variable naming and imports in date picker and shared-access-section tests

Enhancements:

Replace custom UserAvatar with unified AFAvatar component across UI
Improve share tab flow by using BlocConsumer, showing error toasts, and conditional sections
Add i18n localization for share and shared section text
Disable draggable behavior for shared pages in the shared pages list

Build:

Bump AppFlowy version to 1.0.0 in Makefile.toml and pubspec.yaml

Tests:

Update import path in people_with_access_section test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7957 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 5/20/2025 **Status:** ✅ Merged **Merged:** 5/21/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `share_section` --- ### 📝 Commits (10+) - [`246b2f3`](https://github.com/AppFlowy-IO/AppFlowy/commit/246b2f3bf73c33593fffb2f1bbff62dcc35fa80a) chore: bump AppFlowy version to 1.0.0 and add sharedSection feature flag - [`bbe1797`](https://github.com/AppFlowy-IO/AppFlowy/commit/bbe1797c07c60da9187dd3ae7901e090b5e90aab) feat: conditionally display spaces in sidebar based on user role - [`8ebbc4b`](https://github.com/AppFlowy-IO/AppFlowy/commit/8ebbc4b11a532ff4102f8ca8918b4e4ddd11f997) refactor: update user avatar implementation and enhance shared section functionality - [`53319fd`](https://github.com/AppFlowy-IO/AppFlowy/commit/53319fd96b546ad6f76c5bddcfa6eb54943a1473) fix: typo - [`5e37553`](https://github.com/AppFlowy-IO/AppFlowy/commit/5e37553c926ebae3b3cd53420658f4837932e2f1) refactor: enhance share tab functionality and error handling - [`0f09cd4`](https://github.com/AppFlowy-IO/AppFlowy/commit/0f09cd46b769f030f3465a025057167cc78a1053) chore: i18n - [`2e0b802`](https://github.com/AppFlowy-IO/AppFlowy/commit/2e0b802e42b1033d26f38177039d2ed84aab907a) feat: turn guest into member - [`ed2e2e7`](https://github.com/AppFlowy-IO/AppFlowy/commit/ed2e2e7fed8e0e7e7fb3f01828913175f661b88a) fix: unit tests - [`da0b096`](https://github.com/AppFlowy-IO/AppFlowy/commit/da0b096a9a91d2886e84e4c4cc67bf9e1e9aa68e) fix: unit tests - [`97e5d0e`](https://github.com/AppFlowy-IO/AppFlowy/commit/97e5d0ee3f3c23b38ffd176e2e51fb01cda4d864) chore: revert version changes ### 📊 Changes **45 files changed** (+281 additions, -209 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/features/share_tab/data/models/share_access_level.dart` (+7 -4) 📝 `frontend/appflowy_flutter/lib/features/share_tab/data/models/shared_user.dart` (+16 -0) 📝 `frontend/appflowy_flutter/lib/features/share_tab/data/repositories/local_share_with_user_repository.dart` (+14 -0) 📝 `frontend/appflowy_flutter/lib/features/share_tab/data/repositories/rust_share_with_user_repository.dart` (+29 -1) 📝 `frontend/appflowy_flutter/lib/features/share_tab/data/repositories/share_with_user_repository.dart` (+8 -2) 📝 `frontend/appflowy_flutter/lib/features/share_tab/presentation/share_tab.dart` (+34 -13) 📝 `frontend/appflowy_flutter/lib/features/share_tab/presentation/widgets/access_level_list_widget.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/features/share_tab/presentation/widgets/copy_link_widget.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/features/share_tab/presentation/widgets/people_with_access_section.dart` (+5 -5) 📝 `frontend/appflowy_flutter/lib/features/share_tab/presentation/widgets/share_with_user_widget.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/features/share_tab/presentation/widgets/shared_group_widget.dart` (+10 -5) 📝 `frontend/appflowy_flutter/lib/features/share_tab/presentation/widgets/shared_user_widget.dart` (+11 -7) 📝 `frontend/appflowy_flutter/lib/features/shared_section/data/rust_share_pagers_repository.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/features/shared_section/logic/shared_section_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/features/shared_section/presentation/shared_section.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/features/shared_section/presentation/widgets/refresh_button.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/features/shared_section/presentation/widgets/shared_pages_list.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/features/shared_section/presentation/widgets/shared_section_header.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/features/util/extensions.dart` (+27 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/workspace/add_members_screen.dart` (+1 -1) _...and 25 more files_ </details> ### 📄 Description   ### Feature Preview - [x] bump AppFlowy version to 1.0.0 and add sharedSection feature flag - [x] conditionally display spaces in sidebar based on user role - [x] update user avatar implementation and enhance shared sectio… - [x] typo - [x] enhance share tab functionality and error handling - [x] i18n  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. ## Summary by Sourcery Optimize and enhance shared section and sharing UI by introducing a feature flag, refining sidebar visibility, unifying avatar components, bolstering error handling, and adding internationalization. New Features: - Introduce sharedSection feature flag with polling support - Conditionally display shared section and spaces in sidebar based on user role Bug Fixes: - Correct typos in invitation import paths and sidebar upgrade button name - Fix variable naming and imports in date picker and shared-access-section tests Enhancements: - Replace custom UserAvatar with unified AFAvatar component across UI - Improve share tab flow by using BlocConsumer, showing error toasts, and conditional sections - Add i18n localization for share and shared section text - Disable draggable behavior for shared pages in the shared pages list Build: - Bump AppFlowy version to 1.0.0 in Makefile.toml and pubspec.yaml Tests: - Update import path in people_with_access_section test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

mirror

2026-03-23 23:23:14 +00:00

closed this issue
added the
pull-request
label

mirror referenced this issue

2026-03-24 21:36:12 +00:00

[GH-ISSUE #8236] [FR] Add page link into the possible grid column type #11989

No Branch/Tag specified

main

copilot/fix-date-format-issue

feat/mention_a_person

merge_upstream_v6

mobile/release/0.9.3

release/0.9.3

release/0.9.2

select_source

release/0.9.1

refactor_import_data

release/0.8.9.1

release/0.8.9

anon_user_mode

release/0.8.8

fix_windows_selection

release/0.8.7

annieappflowy-patch-1

windows_local_ai

release/0.8.6

release/0.8.5

release/0.8.4

chore/optional-response-format

release/0.8.3

release/0.8.2

release/0.8.1

release/0.8.0

release/0.7.9

feat/support-rename-workspace

chat_rag_only

calculate_ui_test

release/0.7.8

release/0.7.7

stringfi_cells

hotfix/0.7.5

release/0.7.4

client-api-update

feat/collab-editing

fix_calculation_bug

feat/upload-file-in-document

update-client-api

feat/support-global-comment-on-web

update-client-api-2

feat/support-duplicate-publish-on-web

feat/ai-plan-billing

chore/test-web-deploy

chore/enable-billing-for-testing

build/test

ai_tag_feature

chore/enable-billing-plan

feat/billing-client-windows

chore/support-openai-chat

fix/try-no-media-kit

sign-in-error-format

workspace-invite-ci-test

last-workspace

workspace-invite-wip

feat/date-text-input

appflowy_v1

0.11.1

0.11.0

0.10.9

0.11.2

0.10.7

0.10.6

0.10.5

0.11.3

0.11.4

0.10.8

0.10.4

0.10.3

0.10.2

0.10.0

0.10.1

0.9.9

0.9.8

0.9.7

0.9.5

0.9.6

0.9.4

0.9.3

0.9.2

0.9.1

0.9.0

0.8.9

0.8.8

0.8.7

0.8.6

0.8.5

0.8.4

0.8.3

0.8.2

0.8.1

0.8.0

0.7.9

0.7.8

0.7.7

0.7.6

0.7.5

0.7.4

0.7.3

0.7.2

0.7.1

0.7.0

0.6.9

0.6.8

0.6.7.2

0.6.7.1

0.6.7

0.6.6

0.6.5

0.6.4

0.6.3

0.6.2

0.6.1

v0.6.1

0.6.0

0.5.9

0.5.8

0.5.7

0.5.6

0.5.5

0.5.4

0.5.3

0.5.2

0.5.1

0.5.0

0.4.9

0.4.8

0.4.7

0.4.6

0.4.5

0.4.4

0.4.3

0.4.2

0.4.1

0.4.0

0.3.9.1

0.3.9

0.3.8

0.3.7

0.3.6

0.3.5

0.3.4

0.3.3

0.3.2

0.3.1

0.3.0

0.2.9

0.2.8

0.2.7

0.2.6

0.2.5

0.2.4

0.2.3

0.2.2

0.2.1

0.2.0

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.9.1

0.0.9

0.0.8.1

0.0.8

0.0.7.1

0.0.7

0.0.6.2

0.0.6.1

0.0.6

0.0.6_beta.1

0.0.5.3

0.0.5.2

0.0.5.1

0.0.5

0.0.5_beta.2

0.0.5_beta.1

0.0.4

0.0.4_beta.3

0.0.4_beta.2

0.0.4_beta.1

0.0.3

0.0.3_beta.2

0.0.3_beta.1

0.0.2

0.0.1

Labels

Clear labels

good first issue for devs

good first issue for experienced devs

grid

hacktoberfest

HACKTOBERFEST-ACCEPTED

Mirrored from GitHub Pull Request

No labels

good first issue for devs

good first issue for experienced devs

grid

hacktoberfest

HACKTOBERFEST-ACCEPTED

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

AppFlowy-IO/AppFlowy#8236

Reference in a new issue

Repository

AppFlowy-IO/AppFlowy

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns