[PR #7964] [MERGED] fix: LR issues #8241

New issue

Closed

opened 2026-03-23 23:23:16 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:16 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7964
Author: @asjqkkkk
Created: 5/22/2025
Status: ✅ Merged
Merged: 5/22/2025
Merged by: @LucasXu0

Base: main ← Head: fix/desktop/lr

📝 Commits (6)

20f0693 fix: some LR issues
24667b7 fix: add max width for search result title
d235812 fix: update the logic of refreshing chached views
02f0dfa fix: padding issue
a97f73f fix: location of path is wrong
7428009 fix: some UI color issues

📊 Changes

17 files changed (+305 additions, -167 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_ask_ai_entrance.dart (+19 -8)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_cell.dart (+13 -16)
➕ frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_icon.dart (+24 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_result.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_textfield.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_view_ancestors.dart (+13 -12)
📝 frontend/appflowy_flutter/lib/workspace/application/command_palette/command_palette_bloc.dart (+39 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/command_palette/search_result_ext.dart (+18 -12)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/command_palette.dart (+9 -7)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/page_preview.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/recent_views_list.dart (+10 -22)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_field.dart (+1 -1)
➕ frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_icon.dart (+46 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_recent_view_cell.dart (+26 -15)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_result_cell.dart (+59 -57)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_results_list.dart (+12 -7)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_summary_cell.dart (+10 -2)

📄 Description

fix: the position of emoji of search result is incorrect
fix: padding issue
fix: page title should have a max width
fix: double lines
fix: inconsistent background colors

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Ensure command palette displays icons reliably by caching view data and centralizing icon rendering, while refining layout and styles to fix emoji alignment, padding, and text overflow issues

New Features:

Cache and refresh view metadata in CommandPaletteBloc to ensure consistent icon data
Introduce a shared SearchIconExtension to centralize icon rendering for views and search results

Bug Fixes:

Correct emoji alignment and positioning in search result and preview icons
Prevent double-line titles by constraining max widths for page names in search and recent view cells
Standardize hover background colors and adjust padding for consistent UI spacing

Enhancements:

Simplify SearchResultPreview by removing async fetch and using preloaded views directly
Refactor desktop and mobile search/result cells to use unified icon building logic

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7964 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 5/22/2025 **Status:** ✅ Merged **Merged:** 5/22/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/desktop/lr` --- ### 📝 Commits (6) - [`20f0693`](https://github.com/AppFlowy-IO/AppFlowy/commit/20f06931edc279aab19a4a8e022d8c36ad951bfa) fix: some LR issues - [`24667b7`](https://github.com/AppFlowy-IO/AppFlowy/commit/24667b7589cad02d83eb47dc810dff92877e854d) fix: add max width for search result title - [`d235812`](https://github.com/AppFlowy-IO/AppFlowy/commit/d2358120706bb35d225180091d35583c1bd3071a) fix: update the logic of refreshing chached views - [`02f0dfa`](https://github.com/AppFlowy-IO/AppFlowy/commit/02f0dfa59e79f97ac09fe42978b8eeef71c228f7) fix: padding issue - [`a97f73f`](https://github.com/AppFlowy-IO/AppFlowy/commit/a97f73fd279cd96212e78b29f2683da22695de5a) fix: location of path is wrong - [`7428009`](https://github.com/AppFlowy-IO/AppFlowy/commit/7428009c4c09bd60bc627144952718c98dbe6dd2) fix: some UI color issues ### 📊 Changes **17 files changed** (+305 additions, -167 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_ask_ai_entrance.dart` (+19 -8) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_cell.dart` (+13 -16) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_icon.dart` (+24 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_result.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_textfield.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_view_ancestors.dart` (+13 -12) 📝 `frontend/appflowy_flutter/lib/workspace/application/command_palette/command_palette_bloc.dart` (+39 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/command_palette/search_result_ext.dart` (+18 -12) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/command_palette.dart` (+9 -7) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/page_preview.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/recent_views_list.dart` (+10 -22) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_field.dart` (+1 -1) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_icon.dart` (+46 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_recent_view_cell.dart` (+26 -15) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_result_cell.dart` (+59 -57) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_results_list.dart` (+12 -7) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_summary_cell.dart` (+10 -2) </details> ### 📄 Description - fix: the position of emoji of search result is incorrect - fix: padding issue - fix: page title should have a max width - fix: double lines - fix: inconsistent background colors ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Ensure command palette displays icons reliably by caching view data and centralizing icon rendering, while refining layout and styles to fix emoji alignment, padding, and text overflow issues New Features: - Cache and refresh view metadata in CommandPaletteBloc to ensure consistent icon data - Introduce a shared SearchIconExtension to centralize icon rendering for views and search results Bug Fixes: - Correct emoji alignment and positioning in search result and preview icons - Prevent double-line titles by constraining max widths for page names in search and recent view cells - Standardize hover background colors and adjust padding for consistent UI spacing Enhancements: - Simplify SearchResultPreview by removing async fetch and using preloaded views directly - Refactor desktop and mobile search/result cells to use unified icon building logic --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>