[PR #7971] [MERGED] fix: some search LR issues #8246

New issue

Closed

opened 2026-03-23 23:23:18 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7971
Author: @asjqkkkk
Created: 5/23/2025
Status: ✅ Merged
Merged: 5/26/2025
Merged by: @LucasXu0

Base: main ← Head: fix/desktop/lr

📝 Commits (9)

0096c93 fix: some LR issues
efbf462 fix: desktop textstyle issues
02130f8 fix: mobile textstyle issues
f336099 fix: sometimes the path not showing
a9ec71c fix: path displays error, open not exist page toast error
e23056d fix: mobile search page focus issue
871ec08 Merge branch 'main' into fix/desktop/lr
045d746 fix: open page error
abce3f8 fix: some UI issues

📊 Changes

35 files changed (+741 additions, -560 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart (+8 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space_menu.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_ask_ai_entrance.dart (+31 -28)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_cell.dart (+11 -6)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_reference_bottom_sheet.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_result.dart (+38 -13)
➖ frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_special_styles.dart (+0 -24)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_summary_cell.dart (+41 -39)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_textfield.dart (+28 -36)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_view_ancestors.dart (+23 -19)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/view_ancestor_cache.dart (+13 -10)
📝 frontend/appflowy_flutter/lib/startup/startup.dart (+2 -0)
➕ frontend/appflowy_flutter/lib/startup/tasks/af_navigator_observer.dart (+53 -0)
📝 frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart (+80 -19)
📝 frontend/appflowy_flutter/lib/workspace/application/action_navigation/action_navigation_bloc.dart (+15 -2)
📝 frontend/appflowy_flutter/lib/workspace/application/command_palette/command_palette_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/sidebar/space/space_bloc.dart (+10 -6)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/command_palette.dart (+12 -3)
➕ frontend/appflowy_flutter/lib/workspace/presentation/command_palette/navigation_bloc_extension.dart (+14 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/page_preview.dart (+94 -61)

...and 15 more files

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Fix various layout, spacing, and text overflow issues in search and command palette widgets

Bug Fixes:

Prevent duplicate onChanged calls in mobile search textfield
Correct empty search condition to properly clear query
Ensure previews display fallback when view retrieval fails

Enhancements:

Standardize padding and margin across search and command palette components
Implement manual text truncation with ellipsis in page previews
Switch to ListView.builder for search results and filter items based on cached views
Unify icon sizing and alignment in AI and search state widgets

Chores:

Hide TextDirection import conflict in page preview
Remove unused search_icon.svg and obsolete localization imports

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7971 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 5/23/2025 **Status:** ✅ Merged **Merged:** 5/26/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/desktop/lr` --- ### 📝 Commits (9) - [`0096c93`](https://github.com/AppFlowy-IO/AppFlowy/commit/0096c9326d7d9096cc39de64e6888af7f2c3cd77) fix: some LR issues - [`efbf462`](https://github.com/AppFlowy-IO/AppFlowy/commit/efbf462fbde99332695f23f18a96586afced0659) fix: desktop textstyle issues - [`02130f8`](https://github.com/AppFlowy-IO/AppFlowy/commit/02130f8755e1fe874e0b1daa1e7f672b343d61d1) fix: mobile textstyle issues - [`f336099`](https://github.com/AppFlowy-IO/AppFlowy/commit/f33609917545b721c07ffb380a75fb868fe9453e) fix: sometimes the path not showing - [`a9ec71c`](https://github.com/AppFlowy-IO/AppFlowy/commit/a9ec71c3eabd6942839b6accbccea4c7ce9b5322) fix: path displays error, open not exist page toast error - [`e23056d`](https://github.com/AppFlowy-IO/AppFlowy/commit/e23056d37842a4910e58f7d6ecee1e2617572906) fix: mobile search page focus issue - [`871ec08`](https://github.com/AppFlowy-IO/AppFlowy/commit/871ec08a9a19dffe68c6254559108a1f96e22a46) Merge branch 'main' into fix/desktop/lr - [`045d746`](https://github.com/AppFlowy-IO/AppFlowy/commit/045d7462f38c083d0e837e84c2f28ab06cbb3a03) fix: open page error - [`abce3f8`](https://github.com/AppFlowy-IO/AppFlowy/commit/abce3f8a77eadb505307683b90a988d3271b8db4) fix: some UI issues ### 📊 Changes **35 files changed** (+741 additions, -560 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart` (+8 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space_menu.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_ask_ai_entrance.dart` (+31 -28) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_cell.dart` (+11 -6) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_reference_bottom_sheet.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_result.dart` (+38 -13) ➖ `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_special_styles.dart` (+0 -24) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_summary_cell.dart` (+41 -39) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_textfield.dart` (+28 -36) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_view_ancestors.dart` (+23 -19) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/view_ancestor_cache.dart` (+13 -10) 📝 `frontend/appflowy_flutter/lib/startup/startup.dart` (+2 -0) ➕ `frontend/appflowy_flutter/lib/startup/tasks/af_navigator_observer.dart` (+53 -0) 📝 `frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart` (+80 -19) 📝 `frontend/appflowy_flutter/lib/workspace/application/action_navigation/action_navigation_bloc.dart` (+15 -2) 📝 `frontend/appflowy_flutter/lib/workspace/application/command_palette/command_palette_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/sidebar/space/space_bloc.dart` (+10 -6) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/command_palette.dart` (+12 -3) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/navigation_bloc_extension.dart` (+14 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/page_preview.dart` (+94 -61) _...and 15 more files_ </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Fix various layout, spacing, and text overflow issues in search and command palette widgets Bug Fixes: - Prevent duplicate onChanged calls in mobile search textfield - Correct empty search condition to properly clear query - Ensure previews display fallback when view retrieval fails Enhancements: - Standardize padding and margin across search and command palette components - Implement manual text truncation with ellipsis in page previews - Switch to ListView.builder for search results and filter items based on cached views - Unify icon sizing and alignment in AI and search state widgets Chores: - Hide TextDirection import conflict in page preview - Remove unused search_icon.svg and obsolete localization imports --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>