[PR #7984] [MERGED] fix: some search LR issues #8252

Closed
opened 2026-03-23 23:23:19 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7984
Author: @asjqkkkk
Created: 5/26/2025
Status: Merged
Merged: 5/27/2025
Merged by: @LucasXu0

Base: mainHead: fix/search/lr


📝 Commits (2)

  • 0acbbd0 fix: some search LR issues
  • 2fb3341 fix: revamp search textfield hint text

📊 Changes

11 files changed (+129 additions, -103 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_reference_bottom_sheet.dart (+20 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_result.dart (+21 -24)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_textfield.dart (+2 -8)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_view_ancestors.dart (+10 -7)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/page_preview.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/recent_views_list.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_ask_ai_entrance.dart (+60 -56)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_field.dart (+6 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_results_list.dart (+3 -2)
📝 frontend/resources/translations/en-US.json (+1 -0)

📄 Description

  • Increase page reference bottom sheet draggable area height
  • Max width of page title
  • Last item align issue

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Fix inconsistent layout and styling issues in search and command palette components across desktop and mobile interfaces.

Bug Fixes:

  • Fix inconsistent paddings and spacings in ask-AI, searching, overview, result list, recent views, and page preview widgets.
  • Correct text style variants in no-result, overview, recent views, and search result headings for uniform typography.

Enhancements:

  • Parameterize bottom sheet drag handle and add an Android-specific drag handle implementation.
  • Allow multiline ancestor path display and use flexible layout for mobile search ancestors.
  • Update search textfield styles to use themed typography instead of hardcoded values.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7984 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 5/26/2025 **Status:** ✅ Merged **Merged:** 5/27/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/search/lr` --- ### 📝 Commits (2) - [`0acbbd0`](https://github.com/AppFlowy-IO/AppFlowy/commit/0acbbd02e49f32dbc4dbc57cc67de6dea07f12c7) fix: some search LR issues - [`2fb3341`](https://github.com/AppFlowy-IO/AppFlowy/commit/2fb33413d6967d3a733a0aeb6b459ec76892feda) fix: revamp search textfield hint text ### 📊 Changes **11 files changed** (+129 additions, -103 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_reference_bottom_sheet.dart` (+20 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_result.dart` (+21 -24) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_textfield.dart` (+2 -8) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_view_ancestors.dart` (+10 -7) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/page_preview.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/recent_views_list.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_ask_ai_entrance.dart` (+60 -56) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_field.dart` (+6 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_results_list.dart` (+3 -2) 📝 `frontend/resources/translations/en-US.json` (+1 -0) </details> ### 📄 Description - Increase page reference bottom sheet draggable area height - Max width of page title - Last item align issue ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Fix inconsistent layout and styling issues in search and command palette components across desktop and mobile interfaces. Bug Fixes: - Fix inconsistent paddings and spacings in ask-AI, searching, overview, result list, recent views, and page preview widgets. - Correct text style variants in no-result, overview, recent views, and search result headings for uniform typography. Enhancements: - Parameterize bottom sheet drag handle and add an Android-specific drag handle implementation. - Allow multiline ancestor path display and use flexible layout for mobile search ancestors. - Update search textfield styles to use themed typography instead of hardcoded values. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:23:19 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#8252
No description provided.