[PR #7991] [MERGED] fix: database padding issue with max document width #8258

Closed
opened 2026-03-23 23:23:21 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7991
Author: @asjqkkkk
Created: 5/27/2025
Status: Merged
Merged: 5/28/2025
Merged by: @LucasXu0

Base: mainHead: fix/lr/issues


📝 Commits (2)

  • 72be96a fix: adjust the bottom sheet menu drag area
  • 54f3f98 fix: database padding issue with max document width

📊 Changes

6 files changed (+152 additions, -108 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_reference_bottom_sheet.dart (+4 -6)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_hidden_groups.dart (+9 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_page.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/grid_page.dart (+15 -7)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/grid_header.dart (+9 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/tab_bar/tab_bar_view.dart (+112 -88)

📄 Description

  • fix: database padding issue with max document width
  • fix: adjust the drag area of bottom sheet menu in mobole search page

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Fix horizontal padding in database views when a max document width is set by computing and injecting dynamic left padding, and refine the bottom sheet drag area on mobile search.

Bug Fixes:

  • Center database content correctly by adjusting padding based on the max document width.
  • Limit and standardize the drag area of the mobile search bottom sheet to 95% height and always show the drag handle.

Enhancements:

  • Refactor the database tab bar view to wrap content in a LayoutBuilder and provide calculated padding via a new DatabaseWidgetPaddingWithMaxWidth provider.
  • Update grid, board hidden groups, header, and calendar widgets to consume the injected padding for consistent alignment.
  • Simplify mobile bottom sheet implementation by removing platform-specific drag handle logic and using a fixed drag handle builder.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7991 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 5/27/2025 **Status:** ✅ Merged **Merged:** 5/28/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/lr/issues` --- ### 📝 Commits (2) - [`72be96a`](https://github.com/AppFlowy-IO/AppFlowy/commit/72be96aee1c1f4e374f4614b8dbe01f6b536f32e) fix: adjust the bottom sheet menu drag area - [`54f3f98`](https://github.com/AppFlowy-IO/AppFlowy/commit/54f3f9827a1026232aee36bbd3c487a10d0c2703) fix: database padding issue with max document width ### 📊 Changes **6 files changed** (+152 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_reference_bottom_sheet.dart` (+4 -6) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_hidden_groups.dart` (+9 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_page.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/grid_page.dart` (+15 -7) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/grid_header.dart` (+9 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/tab_bar/tab_bar_view.dart` (+112 -88) </details> ### 📄 Description - fix: database padding issue with max document width - fix: adjust the drag area of bottom sheet menu in mobole search page ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Fix horizontal padding in database views when a max document width is set by computing and injecting dynamic left padding, and refine the bottom sheet drag area on mobile search. Bug Fixes: - Center database content correctly by adjusting padding based on the max document width. - Limit and standardize the drag area of the mobile search bottom sheet to 95% height and always show the drag handle. Enhancements: - Refactor the database tab bar view to wrap content in a LayoutBuilder and provide calculated padding via a new DatabaseWidgetPaddingWithMaxWidth provider. - Update grid, board hidden groups, header, and calendar widgets to consume the injected padding for consistent alignment. - Simplify mobile bottom sheet implementation by removing platform-specific drag handle logic and using a fixed drag handle builder. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:23:21 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#8258
No description provided.