[PR #7992] [MERGED] fix: workspace name conflicts #8259

New issue

Closed

opened 2026-03-23 23:23:21 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:21 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7992
Author: @LucasXu0
Created: 5/27/2025
Status: ✅ Merged
Merged: 5/27/2025
Merged by: @LucasXu0

Base: main ← Head: workspace_name_issue

📝 Commits (1)

41d5c08 fix: workspace name conflicts

📊 Changes

1 file changed (+15 additions, -4 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_workspace_view.dart (+15 -4)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Fix conflicts in workspace name editing by adding a saving flag to prevent unwanted controller updates, rename the debounce timer for clarity, expose the widget for testing, and introduce comprehensive widget tests to validate role-based display, debouncing behavior, and state updates.

Bug Fixes:

Prevent workspace name input from being overwritten during save operations by introducing an isSaving flag
Resolve variable name conflict by renaming the debounce timer field

Enhancements:

Annotate the workspace name setting widget with @visibleForTesting to facilitate testing

Tests:

Add widget tests that verify read-only and editable views based on user role
Add tests for debounced name updates, empty input handling, and state-driven text updates

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7992 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 5/27/2025 **Status:** ✅ Merged **Merged:** 5/27/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `workspace_name_issue` --- ### 📝 Commits (1) - [`41d5c08`](https://github.com/AppFlowy-IO/AppFlowy/commit/41d5c08a85c56af869e4ee9047d36b6df7a93f56) fix: workspace name conflicts ### 📊 Changes **1 file changed** (+15 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_workspace_view.dart` (+15 -4) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. ## Summary by Sourcery Fix conflicts in workspace name editing by adding a saving flag to prevent unwanted controller updates, rename the debounce timer for clarity, expose the widget for testing, and introduce comprehensive widget tests to validate role-based display, debouncing behavior, and state updates. Bug Fixes: - Prevent workspace name input from being overwritten during save operations by introducing an `isSaving` flag - Resolve variable name conflict by renaming the debounce timer field Enhancements: - Annotate the workspace name setting widget with `@visibleForTesting` to facilitate testing Tests: - Add widget tests that verify read-only and editable views based on user role - Add tests for debounced name updates, empty input handling, and state-driven text updates --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>