[PR #8003] [CLOSED] chore: adjust create workspace ui #8265

New issue

Closed

opened 2026-03-23 23:23:23 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:23 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/8003
Author: @richardshiue
Created: 5/29/2025
Status: ❌ Closed

Base: main ← Head: feat/create-workspace-modal

📝 Commits (1)

bbef561 chore: adjust create workspace ui

📊 Changes

5 files changed (+280 additions, -232 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_icon_popup.dart (+0 -193)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart (+18 -38)
➕ frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/create_workspace_dialog.dart (+255 -0)
📝 frontend/resources/translations/en-US.json (+6 -1)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Refactor and enhance the workspace creation flow by extracting the dialog into a dedicated component, redesigning the UI, and updating the create workspace button to use the new modal.

Enhancements:

Extract the create workspace dialog UI into a new StatefulWidget in its own file
Replace inline dialog logic in the sidebar with a reusable showCreateWorkspaceDialog API
Remove legacy SpaceIconPicker and related icon selection code from the sidebar
Simplify imports and drop unused localization dependencies in space icon popup

Tests:

Update integration tests to import and interact with the new create workspace dialog component

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/8003 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 5/29/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/create-workspace-modal` --- ### 📝 Commits (1) - [`bbef561`](https://github.com/AppFlowy-IO/AppFlowy/commit/bbef561f11e2e4d8dcbfc7482f1419daefb74500) chore: adjust create workspace ui ### 📊 Changes **5 files changed** (+280 additions, -232 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_icon_popup.dart` (+0 -193) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart` (+18 -38) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/create_workspace_dialog.dart` (+255 -0) 📝 `frontend/resources/translations/en-US.json` (+6 -1) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Refactor and enhance the workspace creation flow by extracting the dialog into a dedicated component, redesigning the UI, and updating the create workspace button to use the new modal. Enhancements: - Extract the create workspace dialog UI into a new StatefulWidget in its own file - Replace inline dialog logic in the sidebar with a reusable showCreateWorkspaceDialog API - Remove legacy SpaceIconPicker and related icon selection code from the sidebar - Simplify imports and drop unused localization dependencies in space icon popup Tests: - Update integration tests to import and interact with the new create workspace dialog component --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>