[PR #8006] [MERGED] refactor: workspace icon #8268

New issue

Closed

opened 2026-03-23 23:23:23 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:23 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/8006
Author: @richardshiue
Created: 5/30/2025
Status: ✅ Merged
Merged: 5/30/2025
Merged by: @richardshiue

Base: main ← Head: refactor/workspace-icon

📝 Commits (1)

a8dda00 refactor: workspace icon

📊 Changes

7 files changed (+52 additions, -56 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/change_name_and_icon_test.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart (+3 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/workspaces/workspace_menu_bottom_sheet.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_icon.dart (+23 -23)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart (+4 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_workspace_view.dart (+12 -18)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Refactor the WorkspaceIcon component API and internal styling, consolidate imports, and update all call sites and tests to use the new props and color logic.

Enhancements:

Refactor WorkspaceIcon to accept workspaceIcon and workspaceName strings instead of a workspace object and rename enableEdit to isEditable.
Update color generation to return separate text and background colors and apply them in the icon container styling.
Clean up and consolidate import statements and simplify container decoration logic.
Propagate WorkspaceIcon API changes across settings, sidebar, mobile views, and bottom sheets.

Tests:

Update integration tests to expect the new workspaceIcon and workspaceName properties on WorkspaceIcon.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/8006 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 5/30/2025 **Status:** ✅ Merged **Merged:** 5/30/2025 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `refactor/workspace-icon` --- ### 📝 Commits (1) - [`a8dda00`](https://github.com/AppFlowy-IO/AppFlowy/commit/a8dda00fdac0c5a81b5ab64d02ece569d40d359e) refactor: workspace icon ### 📊 Changes **7 files changed** (+52 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/change_name_and_icon_test.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart` (+3 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/workspaces/workspace_menu_bottom_sheet.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_icon.dart` (+23 -23) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart` (+4 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_workspace_view.dart` (+12 -18) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Refactor the WorkspaceIcon component API and internal styling, consolidate imports, and update all call sites and tests to use the new props and color logic. Enhancements: - Refactor WorkspaceIcon to accept workspaceIcon and workspaceName strings instead of a workspace object and rename enableEdit to isEditable. - Update color generation to return separate text and background colors and apply them in the icon container styling. - Clean up and consolidate import statements and simplify container decoration logic. - Propagate WorkspaceIcon API changes across settings, sidebar, mobile views, and bottom sheets. Tests: - Update integration tests to expect the new workspaceIcon and workspaceName properties on WorkspaceIcon. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>