[PR #8010] [MERGED] chore: remove change and reset path settings #8269

New issue

Closed

opened 2026-03-23 23:23:23 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:23 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/8010
Author: @richardshiue
Created: 6/2/2025
Status: ✅ Merged
Merged: 6/5/2025
Merged by: @LucasXu0

Base: main ← Head: chore/remove-change-path

📝 Commits (9)

d627fe4 chore: remove change and reset path settings
6f79a96 chore: show reset when custom
26f478d chore: tooltip
0beae1d chore: reorganize code
b6e5564 chore: reorganize code
2cfc9a8 chore: use bloc instead and move logic to repository
a6fcfd2 chore: listener
f213f6c chore: enable for cloud
61e32af chore: add bloc test

📊 Changes

13 files changed (+477 additions, -185 deletions)

View changed files

➕ frontend/appflowy_flutter/lib/features/settings/data/models/user_data_location.dart (+14 -0)
➕ frontend/appflowy_flutter/lib/features/settings/data/repositories/rust_settings_repository_impl.dart (+61 -0)
➕ frontend/appflowy_flutter/lib/features/settings/data/repositories/settings_repository.dart (+14 -0)
➕ frontend/appflowy_flutter/lib/features/settings/logic/data_location_bloc.dart (+76 -0)
➕ frontend/appflowy_flutter/lib/features/settings/logic/data_location_event.dart (+24 -0)
➕ frontend/appflowy_flutter/lib/features/settings/logic/data_location_state.dart (+29 -0)
➕ frontend/appflowy_flutter/lib/features/settings/settings.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/user/application/user_settings_service.dart (+2 -0)
➖ frontend/appflowy_flutter/lib/workspace/application/settings/settings_location_cubit.dart (+0 -46)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_manage_data_view.dart (+145 -124)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/settings_dialog.dart (+14 -11)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialog_v2.dart (+2 -4)
➕ frontend/appflowy_flutter/test/bloc_test/lib/features/settings/data_location_bloc_test.dart (+90 -0)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Remove the ability to change or reset the data storage path and refactor the current path display to use consistent theming, interactive hover effects, and improved copy/open actions.

Enhancements:

Convert the data path text into a clickable link that opens the directory via system file manager
Replace hover handling with MouseRegion and GestureDetector, applying AppFlowyTheme for styling and spacing
Upgrade the copy-to-clipboard button to use an IndexedStack with a tooltip and theme-aware UI
Remove legacy change/reset actions and their associated widgets and imports

Chores:

Remove unused imports and comment out obsolete path-setting code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/8010 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 6/2/2025 **Status:** ✅ Merged **Merged:** 6/5/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `chore/remove-change-path` --- ### 📝 Commits (9) - [`d627fe4`](https://github.com/AppFlowy-IO/AppFlowy/commit/d627fe4ae1980632aefc76862a7d5c6ade22882c) chore: remove change and reset path settings - [`6f79a96`](https://github.com/AppFlowy-IO/AppFlowy/commit/6f79a96baed62b4dded5dfb6633642bbf0077e0a) chore: show reset when custom - [`26f478d`](https://github.com/AppFlowy-IO/AppFlowy/commit/26f478dcfecf8f05b9f5089b9386a94277141bdb) chore: tooltip - [`0beae1d`](https://github.com/AppFlowy-IO/AppFlowy/commit/0beae1d729ab0c8b37db8660ae91c22114925519) chore: reorganize code - [`b6e5564`](https://github.com/AppFlowy-IO/AppFlowy/commit/b6e5564a58e13b9d0418f828d438a97f58da9e9c) chore: reorganize code - [`2cfc9a8`](https://github.com/AppFlowy-IO/AppFlowy/commit/2cfc9a8b290d9ab217b1fb1332877840edc6b08a) chore: use bloc instead and move logic to repository - [`a6fcfd2`](https://github.com/AppFlowy-IO/AppFlowy/commit/a6fcfd2d3fa471fb3ce6147dba087fea0e6217fa) chore: listener - [`f213f6c`](https://github.com/AppFlowy-IO/AppFlowy/commit/f213f6cf9d79a336d90331e766c6811eaa0bfad0) chore: enable for cloud - [`61e32af`](https://github.com/AppFlowy-IO/AppFlowy/commit/61e32afb172b46328aaba84d1dd0a81490939777) chore: add bloc test ### 📊 Changes **13 files changed** (+477 additions, -185 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/lib/features/settings/data/models/user_data_location.dart` (+14 -0) ➕ `frontend/appflowy_flutter/lib/features/settings/data/repositories/rust_settings_repository_impl.dart` (+61 -0) ➕ `frontend/appflowy_flutter/lib/features/settings/data/repositories/settings_repository.dart` (+14 -0) ➕ `frontend/appflowy_flutter/lib/features/settings/logic/data_location_bloc.dart` (+76 -0) ➕ `frontend/appflowy_flutter/lib/features/settings/logic/data_location_event.dart` (+24 -0) ➕ `frontend/appflowy_flutter/lib/features/settings/logic/data_location_state.dart` (+29 -0) ➕ `frontend/appflowy_flutter/lib/features/settings/settings.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/user/application/user_settings_service.dart` (+2 -0) ➖ `frontend/appflowy_flutter/lib/workspace/application/settings/settings_location_cubit.dart` (+0 -46) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_manage_data_view.dart` (+145 -124) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/settings_dialog.dart` (+14 -11) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialog_v2.dart` (+2 -4) ➕ `frontend/appflowy_flutter/test/bloc_test/lib/features/settings/data_location_bloc_test.dart` (+90 -0) </details> ### 📄 Description ![Screenshot 2025-06-02 at 11 11 48 AM](https://github.com/user-attachments/assets/7cbf9b2f-8500-4af6-9602-f67e130eb476) ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. ## Summary by Sourcery Remove the ability to change or reset the data storage path and refactor the current path display to use consistent theming, interactive hover effects, and improved copy/open actions. Enhancements: - Convert the data path text into a clickable link that opens the directory via system file manager - Replace hover handling with MouseRegion and GestureDetector, applying AppFlowyTheme for styling and spacing - Upgrade the copy-to-clipboard button to use an IndexedStack with a tooltip and theme-aware UI - Remove legacy change/reset actions and their associated widgets and imports Chores: - Remove unused imports and comment out obsolete path-setting code --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>