[PR #8059] [MERGED] refactor: rename dialog #8288

New issue

Closed

opened 2026-03-23 23:23:29 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/8059
Author: @richardshiue
Created: 6/13/2025
Status: ✅ Merged
Merged: 6/16/2025
Merged by: @richardshiue

Base: main ← Head: refactor/rename-dialog

📝 Commits (2)

1fa0447 refactor: rename dialog
30851db test: fix test

📊 Changes

19 files changed (+269 additions, -226 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_rename_untitled_test.dart (+6 -6)
📝 frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/change_name_and_icon_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/collaborative_workspace_test.dart (+6 -11)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_create_and_delete_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_sub_page_test.dart (+3 -2)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+13 -14)
📝 frontend/appflowy_flutter/integration_test/shared/database_test_op.dart (+5 -9)
📝 frontend/appflowy_flutter/integration_test/shared/workspace.dart (+16 -17)
📝 frontend/appflowy_flutter/lib/features/shared_section/presentation/shared_section.dart (+6 -5)
📝 frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart (+6 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/favorites/favorite_more_actions.dart (+6 -6)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/sidebar_space_header.dart (+6 -5)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_actions.dart (+6 -5)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart (+6 -22)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+7 -6)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialog_v2.dart (+157 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialogs.dart (+0 -103)
📝 frontend/appflowy_flutter/packages/appflowy_ui/lib/src/component/modal/modal.dart (+11 -6)
📝 frontend/appflowy_flutter/packages/appflowy_ui/lib/src/component/textfield/textfield.dart (+7 -0)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/8059 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 6/13/2025 **Status:** ✅ Merged **Merged:** 6/16/2025 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `refactor/rename-dialog` --- ### 📝 Commits (2) - [`1fa0447`](https://github.com/AppFlowy-IO/AppFlowy/commit/1fa0447b60b608fdbcef5df49a34a70d7df062aa) refactor: rename dialog - [`30851db`](https://github.com/AppFlowy-IO/AppFlowy/commit/30851dbcdad4eaba2013edcdf3de267bc9778316) test: fix test ### 📊 Changes **19 files changed** (+269 additions, -226 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_rename_untitled_test.dart` (+6 -6) 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/change_name_and_icon_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/collaborative_workspace_test.dart` (+6 -11) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_create_and_delete_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_sub_page_test.dart` (+3 -2) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+13 -14) 📝 `frontend/appflowy_flutter/integration_test/shared/database_test_op.dart` (+5 -9) 📝 `frontend/appflowy_flutter/integration_test/shared/workspace.dart` (+16 -17) 📝 `frontend/appflowy_flutter/lib/features/shared_section/presentation/shared_section.dart` (+6 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart` (+6 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/favorites/favorite_more_actions.dart` (+6 -6) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/sidebar_space_header.dart` (+6 -5) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_actions.dart` (+6 -5) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart` (+6 -22) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+7 -6) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialog_v2.dart` (+157 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialogs.dart` (+0 -103) 📝 `frontend/appflowy_flutter/packages/appflowy_ui/lib/src/component/modal/modal.dart` (+11 -6) 📝 `frontend/appflowy_flutter/packages/appflowy_ui/lib/src/component/textfield/textfield.dart` (+7 -0) </details> ### 📄 Description ![Screenshot 2025-06-13 at 10 56 44 AM](https://github.com/user-attachments/assets/77147fe9-cb8c-4392-add8-ef942f3f803d) ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>