[PR #8279] [CLOSED] New Update settings_shortcuts_view.dart #8332

New issue

Closed

opened 2026-03-23 23:23:41 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/8279
Author: @Aathish101
Created: 10/9/2025
Status: ❌ Closed

Base: main ← Head: patch-3

📝 Commits (1)

b608343 New Update settings_shortcuts_view.dart

📊 Changes

1 file changed (+93 additions, -53 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_shortcuts_view.dart (+93 -53)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Refactor settings_shortcuts_view.dart to enhance hover interactions, streamline layout, and improve keybinding editing behavior

Enhancements:

Refactor ResetButton to use FlowyHover builder with persistent hover state and custom hover style
Add hover‐dependent icon and text color changes for ResetButton
Adjust ShortcutSettingTile layout by adding mainAxisAlignment and mainAxisSize.min and removing unnecessary Expanded widgets
Introduce TapRegion onTapOutside to exit keybind edit mode
Simplify keybinding parsing and command conversion extensions
Remove redundant blank lines and perform general code cleanup

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/8279 **Author:** [@Aathish101](https://github.com/Aathish101) **Created:** 10/9/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-3` --- ### 📝 Commits (1) - [`b608343`](https://github.com/AppFlowy-IO/AppFlowy/commit/b60834349cfd4c7491ea5f65b4b38f9837f259a3) New Update settings_shortcuts_view.dart ### 📊 Changes **1 file changed** (+93 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_shortcuts_view.dart` (+93 -53) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Refactor settings_shortcuts_view.dart to enhance hover interactions, streamline layout, and improve keybinding editing behavior Enhancements: - Refactor ResetButton to use FlowyHover builder with persistent hover state and custom hover style - Add hover‐dependent icon and text color changes for ResetButton - Adjust ShortcutSettingTile layout by adding mainAxisAlignment and mainAxisSize.min and removing unnecessary Expanded widgets - Introduce TapRegion onTapOutside to exit keybind edit mode - Simplify keybinding parsing and command conversion extensions - Remove redundant blank lines and perform general code cleanup --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>