[PR #8286] [CLOSED] to reduce load time &white space #8338

New issue

Closed

opened 2026-03-23 23:23:43 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/8286
Author: @ShekFarman
Created: 10/10/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (2)

3e75cfe Update build.rs
5654aa2 update code

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 frontend/rust-lib/dart-ffi/build.rs (+11 -0)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Gate Dart protobuf code generation behind the "dart" feature flag and add logging to indicate when generation runs or is skipped

Enhancements:

Wrap Dart codegen calls in cfg(feature="dart") blocks to avoid unconditional generation
Add println messages for both enabled and disabled Dart feature cases in the build script

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/8286 **Author:** [@ShekFarman](https://github.com/ShekFarman) **Created:** 10/10/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`3e75cfe`](https://github.com/AppFlowy-IO/AppFlowy/commit/3e75cfe6175aec8d4eb5472036bb8eba6e9ca5fd) Update build.rs - [`5654aa2`](https://github.com/AppFlowy-IO/AppFlowy/commit/5654aa25f95a290b6c89266dd455becd53d56ff2) update code ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/dart-ffi/build.rs` (+11 -0) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Gate Dart protobuf code generation behind the "dart" feature flag and add logging to indicate when generation runs or is skipped Enhancements: - Wrap Dart codegen calls in cfg(feature="dart") blocks to avoid unconditional generation - Add println messages for both enabled and disabled Dart feature cases in the build script --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>