[PR #8426] fix: Add missing autofillHints param to AFTextField to fix build error #8353

Open
opened 2026-03-23 23:23:48 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/8426
Author: @ardenspace
Created: 1/10/2026
Status: 🔄 Open

Base: mainHead: fix/aftextfield-build-error


📝 Commits (1)

  • 5ce1b8b fix: add missing autofillHints to AFTextField to fix build error

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 frontend/appflowy_flutter/packages/appflowy_ui/lib/src/component/textfield/textfield.dart (+5 -0)

📄 Description

Description

Fixes build error caused by missing autofillHints parameter in AFTextField widget definition. The parameter was being used in password fields but wasn't defined in the widget, causing compilation errors.

Changes

  • Added autofillHints parameter to AFTextField constructor
  • Added field declaration: final Iterable<String>? autofillHints;
  • Passed autofillHints to the internal TextField widget

Results

image

Fixes

fixes #8425


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Bug Fixes:

  • Fix compilation error by defining and wiring through the autofillHints parameter used by AFTextField consumers.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/8426 **Author:** [@ardenspace](https://github.com/ardenspace) **Created:** 1/10/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/aftextfield-build-error` --- ### 📝 Commits (1) - [`5ce1b8b`](https://github.com/AppFlowy-IO/AppFlowy/commit/5ce1b8b2e4a9a4832d52f9c455a16eb48afefeb0) fix: add missing autofillHints to AFTextField to fix build error ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/packages/appflowy_ui/lib/src/component/textfield/textfield.dart` (+5 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> ## Description Fixes build error caused by missing `autofillHints` parameter in `AFTextField` widget definition. The parameter was being used in password fields but wasn't defined in the widget, causing compilation errors. ## Changes - Added `autofillHints` parameter to `AFTextField` constructor - Added field declaration: `final Iterable<String>? autofillHints;` - Passed `autofillHints` to the internal `TextField` widget ## Results <img width="1063" height="532" alt="image" src="https://github.com/user-attachments/assets/8312d333-b3e5-46ac-8884-78bb34e38c9a" /> ## Fixes fixes #8425 --- #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. ## Summary by Sourcery Bug Fixes: - Fix compilation error by defining and wiring through the autofillHints parameter used by AFTextField consumers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#8353
No description provided.