AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 04:46:56 +00:00

[GH-ISSUE #2199] [FR] Handle invalid URLs when formatting text as a link #899

New issue

Closed

opened 2026-03-23 20:42:48 +00:00 by mirror · 12 comments

mirror commented

2026-03-23 20:42:48 +00:00

Owner

Originally created by @annieappflowy on GitHub (Apr 5, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2199

Description

On the link edition/creation dialog you can type anything and it's still accepted, it should only accept URL (from web URL to system (I don't know how they are called) URL like mailto, call, etc.)

In the link editing menu, we should let the user know "Type a valid URL to link"

Impact

Users who format text as links

Additional Context

No response

Originally created by @annieappflowy on GitHub (Apr 5, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2199 ### Description On the link edition/creation dialog you can type anything and it's still accepted, it should only accept URL (from web URL to system (I don't know how they are called) URL like mailto, call, etc.) In the link editing menu, we should let the user know "Type a valid URL to link" ### Impact Users who format text as links ### Additional Context _No response_

mirror

2026-03-23 20:42:48 +00:00

closed this issue
added the
hacktoberfest

good first issue for devs

2024

help wanted

improvements

editor
labels

mirror commented

2026-03-23 20:42:49 +00:00

Author

Owner

@GouravShDev commented on GitHub (Apr 5, 2023):

I would like to work on this issue.

@GouravShDev commented on GitHub (Apr 5, 2023): I would like to work on this issue.

mirror commented

2026-03-23 20:42:49 +00:00

Author

Owner

@rwt-2001 commented on GitHub (Apr 5, 2023):

@GouravShDev would you let me work on this issue?

@rwt-2001 commented on GitHub (Apr 5, 2023): @GouravShDev would you let me work on this issue?

mirror commented

2026-03-23 20:42:49 +00:00

Author

Owner

@GouravShDev commented on GitHub (Apr 5, 2023):

@rwt-2001 sure.

@GouravShDev commented on GitHub (Apr 5, 2023): @rwt-2001 sure.

mirror commented

2026-03-23 20:42:49 +00:00

Author

Owner

@annieappflowy commented on GitHub (Apr 5, 2023):

Thanks @GouravShDev. I think there are other interesting issues to take :D
Assigned it to @rwt-2001

@annieappflowy commented on GitHub (Apr 5, 2023): Thanks @GouravShDev. I think there are other interesting issues to take :D Assigned it to @rwt-2001

mirror commented

2026-03-23 20:42:49 +00:00

Author

Owner

@Xazin commented on GitHub (Apr 23, 2023):

The PR linked to this does not change any behavior inside the link menu, are we sure this is completed?

@Xazin commented on GitHub (Apr 23, 2023): The PR linked to this does not change any behavior inside the link menu, are we sure this is completed?

mirror commented

2026-03-23 20:42:50 +00:00

Author

Owner

@Chandan-CV commented on GitHub (May 24, 2023):

@annieappflowy @Xazin, if no one working on this, can I take it up? 😃

@Chandan-CV commented on GitHub (May 24, 2023): @annieappflowy @Xazin, if no one working on this, can I take it up? :smiley:

mirror commented

2026-03-23 20:42:50 +00:00

Author

Owner

@Chandan-CV commented on GitHub (May 31, 2023):

@annieappflowy Can you assign me this issue?

@Chandan-CV commented on GitHub (May 31, 2023): @annieappflowy Can you assign me this issue?

mirror commented

2026-03-23 20:42:50 +00:00

Author

Owner

@annieappflowy commented on GitHub (Jul 11, 2023):

Sorry for the late response. Are you still keen to work on it? @Chandan-CV

@annieappflowy commented on GitHub (Jul 11, 2023): Sorry for the late response. Are you still keen to work on it? @Chandan-CV

mirror commented

2026-03-23 20:42:50 +00:00

Author

Owner

@AdiAr11 commented on GitHub (Jul 16, 2023):

Hi @annieappflowy , can i work on this? Also what all changes are required? Like should i change the title from 'Add your link' to 'Type a valid URL to link' and change the functionality by first checking if the link is valid before clicking entering or either of the two?
Thank you!
Screenshot 2023-07-16 at 3 13 13 PM

@AdiAr11 commented on GitHub (Jul 16, 2023): Hi @annieappflowy , can i work on this? Also what all changes are required? Like should i change the title from 'Add your link' to 'Type a valid URL to link' and change the functionality by first checking if the link is valid before clicking entering or either of the two? Thank you! <img width="894" alt="Screenshot 2023-07-16 at 3 13 13 PM" src="https://github.com/AppFlowy-IO/AppFlowy/assets/54585121/4a8b0087-55be-4298-8e9c-3cf57eb0274c">

mirror commented

2026-03-23 20:42:51 +00:00

Author

Owner

@annieappflowy commented on GitHub (Aug 11, 2023):

Hi @AdiAr11 , are you available to work on this?

@annieappflowy commented on GitHub (Aug 11, 2023): Hi @AdiAr11 , are you available to work on this?

mirror commented

2026-03-23 20:42:51 +00:00

Author

Owner

@AdiAr11 commented on GitHub (Aug 11, 2023):

@annieappflowy Yes, I am available!

@AdiAr11 commented on GitHub (Aug 11, 2023): @annieappflowy Yes, I am available!

mirror commented

2026-03-23 20:42:51 +00:00

Author

Owner

@AdiAr11 commented on GitHub (Sep 28, 2023):

@annieappflowy I think the following PR fixes this issue.
https://github.com/AppFlowy-IO/appflowy-editor/pull/324

@AdiAr11 commented on GitHub (Sep 28, 2023): @annieappflowy I think the following PR fixes this issue. [https://github.com/AppFlowy-IO/appflowy-editor/pull/324](https://github.com/AppFlowy-IO/appflowy-editor/pull/324)