AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 04:46:56 +00:00

[GH-ISSUE #2228] [FR] add prefer_final_fields, prefer_final_in_for_each, prefer_final_locals, prefer_final_parameters to analysis_options.yaml #914

New issue

Closed

opened 2026-03-23 20:43:01 +00:00 by mirror · 7 comments

mirror commented

2026-03-23 20:43:01 +00:00

Owner

Originally created by @LucasXu0 on GitHub (Apr 10, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2228

Originally assigned to: @yatendra2001 on GitHub.

https://github.com/AppFlowy-IO/AppFlowy/pull/2219/files#diff-821d01a41fc10f7b1d262ae67e55c3c7592a44b0692999b99207dfaaac1dce66R291

adding the above rules to analysis_options.yaml.
formatting the exsittng code in the same PR.

Originally created by @LucasXu0 on GitHub (Apr 10, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2228 Originally assigned to: @yatendra2001 on GitHub. https://github.com/AppFlowy-IO/AppFlowy/pull/2219/files#diff-821d01a41fc10f7b1d262ae67e55c3c7592a44b0692999b99207dfaaac1dce66R291 * adding the above rules to analysis_options.yaml. * formatting the exsittng code in the same PR.

mirror

2026-03-23 20:43:01 +00:00

closed this issue
added the
good first issue for devs

good first issue for experienced devs

help wanted
labels

mirror commented

2026-03-23 20:43:02 +00:00

Author

Owner

@yatendra2001 commented on GitHub (Jun 4, 2023):

Hey @LucasXu0 @annieappflowy , I would like to work on this issue, can you assign it to me?

@yatendra2001 commented on GitHub (Jun 4, 2023): Hey @LucasXu0 @annieappflowy , I would like to work on this issue, can you assign it to me?

mirror commented

2026-03-23 20:43:02 +00:00

Author

Owner

@LucasXu0 commented on GitHub (Jun 5, 2023):

Sure, @yatendra2001.

@LucasXu0 commented on GitHub (Jun 5, 2023): Sure, @yatendra2001.

mirror commented

2026-03-23 20:43:03 +00:00

Author

Owner

@yatendra2001 commented on GitHub (Jun 5, 2023):

@LucasXu0 I need to create a new PR right?

@yatendra2001 commented on GitHub (Jun 5, 2023): @LucasXu0 I need to create a new PR right?

mirror commented

2026-03-23 20:43:03 +00:00

Author

Owner

@yatendra2001 commented on GitHub (Jun 5, 2023):

@LucasXu0 Opened a PR for this issue at #2708

@yatendra2001 commented on GitHub (Jun 5, 2023): @LucasXu0 Opened a PR for this issue at #2708

mirror commented

2026-03-23 20:43:03 +00:00

Author

Owner

@yatendra2001 commented on GitHub (Jun 5, 2023):

Okay, I need to fix the formatting of the code in this PR as well right?

so it passes the flutter analyzer?

@yatendra2001 commented on GitHub (Jun 5, 2023): Okay, I need to fix the formatting of the code in this PR as well right? so it passes the flutter analyzer?

mirror commented

2026-03-23 20:43:04 +00:00

Author

Owner

@yatendra2001 commented on GitHub (Jun 5, 2023):

Do you know an automated way to achieve that?
There are more than 5k+ lines and manually adding the final to each parameter doesn't seem feasible.

@yatendra2001 commented on GitHub (Jun 5, 2023): Do you know an automated way to achieve that? There are more than 5k+ lines and manually adding the final to each parameter doesn't seem feasible.

mirror commented

2026-03-23 20:43:04 +00:00

Author

Owner

@LucasXu0 commented on GitHub (Jun 5, 2023):

Yep. You should format the code as well. You can use dart fix --apply for most cases.

@LucasXu0 commented on GitHub (Jun 5, 2023): Yep. You should format the code as well. You can use `dart fix --apply` for most cases.

mirror referenced this issue

2026-03-23 21:37:47 +00:00

[PR #914] [MERGED] Fix/card animation #4430