AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 12:56:59 +00:00

[GH-ISSUE #2233] [Bug] Cmd + k triggers the link dialog when no text is selected #916

New issue

Closed

opened 2026-03-23 20:43:07 +00:00 by mirror · 7 comments

mirror commented

2026-03-23 20:43:07 +00:00

Owner

Originally created by @annieappflowy on GitHub (Apr 11, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2233

Originally assigned to: @Chandan-CV on GitHub.

Bug Description

ctrl+k even works if nothing is selected,

meaning if selection is empty then also a link dialog opens up, where you can add the link, but since no text is selected, the whole operation does nothing.

We may fix it by only opening up the link menu when and some text is selected.

How to Reproduce

When the cursor is active, press cmd+k

Expected Behavior

If text selection is empty, cmd+k doesn't trigger the link dialog

Operating System

MacOS

AppFlowy Version(s)

Main branch

Screenshots

No response

Additional Context

No response

Originally created by @annieappflowy on GitHub (Apr 11, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2233 Originally assigned to: @Chandan-CV on GitHub. ### Bug Description ctrl+k even works if nothing is selected, meaning if selection is empty then also a link dialog opens up, where you can add the link, but since no text is selected, the whole operation does nothing. We may fix it by only opening up the link menu when and some text is selected. ### How to Reproduce When the cursor is active, press cmd+k ### Expected Behavior If text selection is empty, cmd+k doesn't trigger the link dialog ### Operating System MacOS ### AppFlowy Version(s) Main branch ### Screenshots _No response_ ### Additional Context _No response_

mirror

2026-03-23 20:43:07 +00:00

closed this issue
added the
good first issue for devs

editor

bug

help wanted
labels

mirror commented

2026-03-23 20:43:08 +00:00

Author

Owner

@rwt-2001 commented on GitHub (Apr 18, 2023):

I would like to work on this issue.

@rwt-2001 commented on GitHub (Apr 18, 2023): I would like to work on this issue.

mirror commented

2026-03-23 20:43:08 +00:00

Author

Owner

@annieappflowy commented on GitHub (May 9, 2023):

Hi @rwt-2001 , I missed your comment. Are you still keen to work on this issue?

@annieappflowy commented on GitHub (May 9, 2023): Hi @rwt-2001 , I missed your comment. Are you still keen to work on this issue?

mirror commented

2026-03-23 20:43:08 +00:00

Author

Owner

@Chandan-CV commented on GitHub (May 9, 2023):

Hi @annieappflowy!
Can I work on this issue?

@Chandan-CV commented on GitHub (May 9, 2023): Hi @annieappflowy! Can I work on this issue?

mirror commented

2026-03-23 20:43:09 +00:00

Author

Owner

@annieappflowy commented on GitHub (May 11, 2023):

Sure. Assigned it to you, @Chandan-CV

@annieappflowy commented on GitHub (May 11, 2023): Sure. Assigned it to you, @Chandan-CV

mirror commented

2026-03-23 20:43:09 +00:00

Author

Owner

@Chandan-CV commented on GitHub (May 12, 2023):

Hi @annieappflowy!
Thank you for assigning me this issue.
I played around a little and figured out the issue is with the appflowy-editor. I took @Xazin's work as a reference, and sent a new PR solving this issue.
AppFlowy-IO/appflowy-editor/pull/117

I am a beginner in open source and AppFlowy, please correct me if I did something wrong, your guidance is appreciated 🚀 😄

Thank you!

@Chandan-CV commented on GitHub (May 12, 2023): Hi @annieappflowy! Thank you for assigning me this issue. I played around a little and figured out the issue is with the appflowy-editor. I took @Xazin's work as a reference, and sent a new PR solving this issue. [AppFlowy-IO/appflowy-editor/pull/117](https://github.com/AppFlowy-IO/appflowy-editor/pull/117) I am a beginner in open source and AppFlowy, please correct me if I did something wrong, your guidance is appreciated :rocket: :smile: Thank you!

mirror commented

2026-03-23 20:43:09 +00:00

Author

Owner

@Chandan-CV commented on GitHub (May 13, 2023):

Screencast from 13-05-23 10:50:23 AM IST.webm

@Chandan-CV commented on GitHub (May 13, 2023): [Screencast from 13-05-23 10:50:23 AM IST.webm](https://github.com/AppFlowy-IO/AppFlowy/assets/37525954/a957b0ae-4e44-408b-b022-0e9b8196b4fb)

mirror commented

2026-03-23 20:43:09 +00:00

Author

Owner

@annieappflowy commented on GitHub (Jul 11, 2023):

Fixed. Thanks everyone!

@annieappflowy commented on GitHub (Jul 11, 2023): Fixed. Thanks everyone!

mirror referenced this issue

2026-03-23 21:37:47 +00:00

[PR #916] [CLOSED] Update install_linux.sh #4431