AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 04:46:56 +00:00

[GH-ISSUE #2293] [Bug] Upload button in dark mode #955

New issue

Closed

opened 2026-03-23 20:43:35 +00:00 by mirror · 10 comments

mirror commented

2026-03-23 20:43:35 +00:00

Owner

Originally created by @annieappflowy on GitHub (Apr 19, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2293

Originally assigned to: @akarsh-jain-790 on GitHub.

Bug Description

How to Reproduce

Use the slash menu
Select image

Expected Behavior

Operating System

MacOS

AppFlowy Version(s)

Main branch

Screenshots

No response

Additional Context

No response

Originally created by @annieappflowy on GitHub (Apr 19, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2293 Originally assigned to: @akarsh-jain-790 on GitHub. ### Bug Description <img width="362" alt="image" src="https://user-images.githubusercontent.com/12026239/233060546-5fa280f1-262a-4adf-a97c-6d9ff9e25a18.png"> ### How to Reproduce Use the slash menu Select image ### Expected Behavior <img width="391" alt="image" src="https://user-images.githubusercontent.com/12026239/233061543-ab363fd7-4f77-415b-96c4-48474ea64592.png"> ### Operating System MacOS ### AppFlowy Version(s) Main branch ### Screenshots _No response_ ### Additional Context _No response_

mirror

2026-03-23 20:43:35 +00:00

closed this issue
added the
improvements
label

mirror commented

2026-03-23 20:43:36 +00:00

Author

Owner

@akarsh-jain-790 commented on GitHub (Apr 24, 2023):

@annieappflowy I would like to work on this, can assign me this issue please?

@akarsh-jain-790 commented on GitHub (Apr 24, 2023): @annieappflowy I would like to work on this, can assign me this issue please?

mirror commented

2026-03-23 20:43:36 +00:00

Author

Owner

@annieappflowy commented on GitHub (Apr 24, 2023):

Sure. Assigned! Thank you ❤️

@annieappflowy commented on GitHub (Apr 24, 2023): Sure. Assigned! Thank you ❤️

mirror commented

2026-03-23 20:43:36 +00:00

Author

Owner

@akarsh-jain-790 commented on GitHub (Apr 25, 2023):

@annieappflowy If I understand the issue correctly, you want me to update the text color of the Upload button to black when in dark mode.

@akarsh-jain-790 commented on GitHub (Apr 25, 2023): @annieappflowy If I understand the issue correctly, you want me to update the text color of the Upload button to black when in dark mode.

mirror commented

2026-03-23 20:43:37 +00:00

Author

Owner

@annieappflowy commented on GitHub (Apr 25, 2023):

Yes, @hyj1204 can provide you with more pointers.

@annieappflowy commented on GitHub (Apr 25, 2023): Yes, @hyj1204 can provide you with more pointers.

mirror commented

2026-03-23 20:43:37 +00:00

Author

Owner

@akarsh-jain-790 commented on GitHub (Apr 25, 2023):

@annieappflowy Also, while addressing the issue, I observed that when attempting to insert an image at the bottom of the document, the image popover becomes concealed beneath the screen.

https://user-images.githubusercontent.com/72064462/234216787-ae55bb63-3bb6-4387-85b3-c7a3b600731e.mov

@akarsh-jain-790 commented on GitHub (Apr 25, 2023): @annieappflowy Also, while addressing the issue, I observed that when attempting to insert an image at the bottom of the document, the image popover becomes concealed beneath the screen. https://user-images.githubusercontent.com/72064462/234216787-ae55bb63-3bb6-4387-85b3-c7a3b600731e.mov

mirror commented

2026-03-23 20:43:37 +00:00

Author

Owner

@hyj1204 commented on GitHub (Apr 26, 2023):

@annieappflowy If I understand the issue correctly, you want me to update the text color of the Upload button to black when in dark mode.

Yes, I think it should be Theme.of(context).colorScheme.onSurface color for the text color

@hyj1204 commented on GitHub (Apr 26, 2023): > @annieappflowy If I understand the issue correctly, you want me to update the text color of the Upload button to black when in dark mode. Yes, I think it should be `Theme.of(context).colorScheme.onSurface` color for the text color

mirror commented

2026-03-23 20:43:38 +00:00

Author

Owner

@annieappflowy commented on GitHub (May 4, 2023):

Hi @akarsh-jain-790 , are you still working on this issue? Let us know if you need more help.

@annieappflowy commented on GitHub (May 4, 2023): Hi @akarsh-jain-790 , are you still working on this issue? Let us know if you need more help.

mirror commented

2026-03-23 20:43:38 +00:00

Author

Owner

@akarsh-jain-790 commented on GitHub (May 4, 2023):

@hyj1204 Do I need to make any changes to the AppFlowy editor?

@akarsh-jain-790 commented on GitHub (May 4, 2023): @hyj1204 Do I need to make any changes to the AppFlowy editor?

mirror commented

2026-03-23 20:43:38 +00:00

Author

Owner

@hyj1204 commented on GitHub (May 5, 2023):

@akarsh-jain-790 Yes, I just moved it to the AppFlowy Editor repo. Please comment here so I can assign it to you.
You can clone the AppFlowy Editor repo to your local path, then change the yaml to your local path, like

It will use your local AppFlowy Editor instead of the release version, so you can make change in your local and see how it will looks in AppFlowy Desktop.

@hyj1204 commented on GitHub (May 5, 2023): @akarsh-jain-790 Yes, I just moved it to the AppFlowy Editor repo. Please comment [here](https://github.com/AppFlowy-IO/appflowy-editor/issues/110#issue-1697754122) so I can assign it to you. You can clone the AppFlowy Editor repo to your local path, then change the yaml to your local path, like ![image](https://user-images.githubusercontent.com/14248245/236493742-74c2558b-654b-4b8c-b36f-4eeb9bfe00f9.png) It will use your local AppFlowy Editor instead of the release version, so you can make change in your local and see how it will looks in AppFlowy Desktop.

mirror commented

2026-03-23 20:43:39 +00:00

Author

Owner

@hyj1204 commented on GitHub (May 5, 2023):

Close this PR since it is the UI part in Appflowy Editor. The migrated issue is here

@hyj1204 commented on GitHub (May 5, 2023): Close this PR since it is the UI part in Appflowy Editor. The migrated issue is [here](https://github.com/AppFlowy-IO/appflowy-editor/issues/110#issue-1697754122)

mirror referenced this issue

2026-03-23 21:37:53 +00:00

[PR #956] [MERGED] fix: #955 upgrade build_resolvers to 2.0.9 #4454