AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 04:46:56 +00:00

[GH-ISSUE #2294] [FR] Handle incorrect image url #956

New issue

Closed

opened 2026-03-23 20:43:35 +00:00 by mirror · 11 comments

mirror commented

2026-03-23 20:43:35 +00:00

Owner

Originally created by @annieappflowy on GitHub (Apr 19, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2294

Originally assigned to: @Xazin on GitHub.

Description

I should not be allowed to upload an image via an incorrect url

Impact

Users who insert images using URLs

Additional Context

No response

Originally created by @annieappflowy on GitHub (Apr 19, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2294 Originally assigned to: @Xazin on GitHub. ### Description I should not be allowed to upload an image via an incorrect url <img width="367" alt="image" src="https://user-images.githubusercontent.com/12026239/233061897-e878ff8f-3b93-422e-ac88-4a97b1737d65.png"> ### Impact Users who insert images using URLs ### Additional Context _No response_

mirror

2026-03-23 20:43:35 +00:00

closed this issue
added the
good first issue for experienced devs

improvements

editor

2024
labels

mirror commented

2026-03-23 20:43:36 +00:00

Author

Owner

@AdiAr11 commented on GitHub (Jul 17, 2023):

Hi, does this issue still need to be fixed? I can work on it if its still need to be fixed. Thank you

@AdiAr11 commented on GitHub (Jul 17, 2023): Hi, does this issue still need to be fixed? I can work on it if its still need to be fixed. Thank you

mirror commented

2026-03-23 20:43:36 +00:00

Author

Owner

@LucasXu0 commented on GitHub (Jul 17, 2023):

@AdiAr11 yes. Assigned it to you.

@LucasXu0 commented on GitHub (Jul 17, 2023): @AdiAr11 yes. Assigned it to you.

mirror commented

2026-03-23 20:43:37 +00:00

Author

Owner

@AdiAr11 commented on GitHub (Jul 17, 2023):

@LucasXu0 Thank you !!

@AdiAr11 commented on GitHub (Jul 17, 2023): @LucasXu0 Thank you !!

mirror commented

2026-03-23 20:43:37 +00:00

Author

Owner

@AdiAr11 commented on GitHub (Jul 17, 2023):

Hi @LucasXu0 , i found the callback for when the image url is not found in image_selection_menu.dart file. could you please tell me where the code for this dialog is?
I am thinking I would add a bool variable 'isUrlValid' in a provider class and change it to true if url is not valid and in catch block of the above mentioned file. then i would listen to the change in this bool value and display the 'Incorrect Link' text in the dialog.
Please let me know if you think it there is a better approach or something else that needs to be changed. Thanks

@AdiAr11 commented on GitHub (Jul 17, 2023): Hi @LucasXu0 , i found the callback for when the image url is not found in image_selection_menu.dart file. could you please tell me where the code for this dialog is? I am thinking I would add a bool variable 'isUrlValid' in a provider class and change it to true if url is not valid and in catch block of the above mentioned file. then i would listen to the change in this bool value and display the 'Incorrect Link' text in the dialog. Please let me know if you think it there is a better approach or something else that needs to be changed. Thanks

mirror commented

2026-03-23 20:43:37 +00:00

Author

Owner

@LucasXu0 commented on GitHub (Jul 18, 2023):

@AdiAr11. Your approach sounds good to me. The code is located in image_upload_widget.dart, and you should submit the PR to this repo.

@LucasXu0 commented on GitHub (Jul 18, 2023): @AdiAr11. Your approach sounds good to me. The code is located in `image_upload_widget.dart`, and you should submit the PR to this [repo](https://github.com/AppFlowy-IO/appflowy-editor).

mirror commented

2026-03-23 20:43:37 +00:00

Author

Owner

@AdiAr11 commented on GitHub (Jul 18, 2023):

@LucasXu0 @annieappflowy Created a PR in this mentioned repo :)

@AdiAr11 commented on GitHub (Jul 18, 2023): @LucasXu0 @annieappflowy Created a PR in this mentioned [repo](https://github.com/AppFlowy-IO/appflowy-editor) :)

mirror commented

2026-03-23 20:43:38 +00:00

Author

Owner

@annieappflowy commented on GitHub (Nov 5, 2023):

Did you manage to get it merged, @AdiAr11 ?

@annieappflowy commented on GitHub (Nov 5, 2023): Did you manage to get it merged, @AdiAr11 ?

mirror commented

2026-03-23 20:43:38 +00:00

Author

Owner

@AdiAr11 commented on GitHub (Nov 5, 2023):

@annieappflowy yes, that pr has been merged.

@AdiAr11 commented on GitHub (Nov 5, 2023): @annieappflowy yes, that pr has been merged.

mirror commented

2026-03-23 20:43:38 +00:00

Author

Owner

@annieappflowy commented on GitHub (Nov 6, 2023):

@AdiAr11 , I can see that it would show "invalid image" after pressing "Enter"
Ideally, it should stay in the upload panel while showing "invalid image link". This way I can fix the image link right away.

@annieappflowy commented on GitHub (Nov 6, 2023): @AdiAr11 , I can see that it would show "invalid image" after pressing "Enter" Ideally, it should stay in the upload panel while showing "invalid image link". This way I can fix the image link right away.

mirror commented

2026-03-23 20:43:39 +00:00

Author

Owner

@AdiAr11 commented on GitHub (Dec 3, 2023):

@annieappflowy sorry, I somehow missed your last comment.
https://github.com/AppFlowy-IO/appflowy-editor/pull/324
In this PR, the popup stays while showing "Incorrect link".

@AdiAr11 commented on GitHub (Dec 3, 2023): @annieappflowy sorry, I somehow missed your last comment. https://github.com/AppFlowy-IO/appflowy-editor/pull/324 In this PR, the popup stays while showing "Incorrect link".

mirror commented

2026-03-23 20:43:39 +00:00

Author

Owner

@annieappflowy commented on GitHub (Dec 24, 2023):

todo: handle it in the menu without clicking the button

@annieappflowy commented on GitHub (Dec 24, 2023): todo: handle it in the menu without clicking the button <img width="522" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/12026239/91288a64-be12-498f-ad12-3fe71f3563b2">

mirror referenced this issue

2026-03-23 21:37:53 +00:00

[PR #956] [MERGED] fix: #955 upgrade build_resolvers to 2.0.9 #4454