RADar-AZDelta/archived-azd-radar-data-datatable
1
0
Fork 0
mirror of https://github.com/RADar-AZDelta/azd-radar-data-datatable.git synced 2026-03-23 20:37:13 +00:00
Code Issues 2 Projects Packages Wiki Activity

[GH-ISSUE #64] private async loadFileInWorker(file: File): Promise<void> { #32

New issue
Closed
opened 2026-03-23 20:33:36 +00:00 by mirror · 2 comments
mirror commented 2026-03-23 20:33:36 +00:00
Owner
Copy link

Originally created by @pjlammertyn on GitHub (Jan 17, 2025).
Original GitHub issue: https://github.com/RADar-AZDelta/azd-radar-data-datatable/issues/64

Originally assigned to: @BostoenToby on GitHub.

When loading a CSV into the datatable, the first time, the loadFileInWorker function is called 2 times.
Schould be only 1 time!

Originally created by @pjlammertyn on GitHub (Jan 17, 2025). Original GitHub issue: https://github.com/RADar-AZDelta/azd-radar-data-datatable/issues/64 Originally assigned to: @BostoenToby on GitHub. When loading a CSV into the datatable, the first time, the [loadFileInWorker](https://github.com/RADar-AZDelta/azd-radar-data-datatable/blob/master/src/lib/helpers/data/dataTypes/DataTypeFile.ts#L39) function is called 2 times. Schould be only 1 time!
mirror commented 2026-03-23 20:33:37 +00:00
Author
Owner
Copy link

@pjlammertyn commented on GitHub (Jan 17, 2025):

Why a seperate validation function? Why not put the validation in the load method?

Also it is possible to load JSON files in the datatable, the validate function assumes that only CSV's are used (check the file extension!).

<!-- gh-comment-id:2598288356 --> @pjlammertyn commented on GitHub (Jan 17, 2025): Why a seperate validation function? Why not put the validation in the load method? Also it is possible to load JSON files in the datatable, the [validate](https://github.com/RADar-AZDelta/azd-radar-data-datatable/blob/master/src/lib/helpers/data/dataTypes/DataTypeFile.ts#L196) function assumes that only CSV's are used (check the file extension!).
mirror commented 2026-03-23 20:33:37 +00:00
Author
Owner
Copy link

@pjlammertyn commented on GitHub (Jan 17, 2025):

Alsook zou de validatie van de CSV een optie moeten zijn, dat default af staat.

<!-- gh-comment-id:2598303619 --> @pjlammertyn commented on GitHub (Jan 17, 2025): Alsook zou de validatie van de CSV een optie moeten zijn, dat default af staat.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/npm_and_yarn/sveltejs/kit-2.20.6
dependabot/npm_and_yarn/vite-6.1.5
demo
svelte5-refactoring
datatable-svelte4
v0.0.12
v0.0.11
v0.0.3
v0.0.2
Labels
Clear labels   
bug

   
bug

   
enhancement

   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
bug
enhancement
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
RADar-AZDelta/archived-azd-radar-data-datatable#32
No description provided.