mirror of
https://github.com/RADar-AZDelta/azd-radar-data-keunFirebase.git
synced 2026-03-23 20:36:48 +00:00
[GH-ISSUE #2] Never store your GCP auth token in a file! This is insecure!!!! #3
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pjlammertyn on GitHub (Jun 20, 2024).
Original GitHub issue: https://github.com/RADar-AZDelta/azd-radar-data-keunFirebase/issues/2
Originally assigned to: @BostoenToby on GitHub.
github.com/RADar-AZDelta/azd-radar-dev-keun@6b23bde84e/docker-build.sh (L2)@BostoenToby commented on GitHub (Jun 20, 2024):
This just to pass to the Dockerfile to be able to have access to the Artifact Registry (private NPM repo). This file isn't stored in Git or anywhere else, so why is this insecure?
@pjlammertyn commented on GitHub (Jun 20, 2024):
Because by default, your files are group or even world readable.
So storing tokens in a file is an anti-pattern. Because nobody checks the read access, and nobody shreds them if they are no longer needed.
@BostoenToby commented on GitHub (Jun 20, 2024):
Understandable, in the latest commit it's stored in a variable in the script and directly used in the docker build command.
Thanks for the feedback!