[PR #2641] [MERGED] feat: group by date #5344

Closed
opened 2026-03-23 22:18:19 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2641
Author: @zoli
Created: 5/28/2023
Status: Merged
Merged: 8/14/2023
Merged by: @appflowy

Base: mainHead: feat/group-by-date-iss1174-develop


📝 Commits (10+)

  • 12077ad feat: group by date
  • 79a76cc test: added more tests for group by date
  • 0305cd8 fix: print month in abbrev format
  • aca2612 chore: adapt group event changes
  • ffad056 style: remove comment
  • 2c6101d fix: change date on changing group
  • 0f8034d chore: merge develop
  • 4fba38f fix: dont count time in relative group
  • 25291ec chore: merge develop
  • 0e723e9 fix: check beginning of month is within 30 days

📊 Changes

12 files changed (+891 additions, -40 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_info.dart (+1 -0)
📝 frontend/rust-lib/flowy-database2/src/entities/group_entities/configuration.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option.rs (+14 -12)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option_entities.rs (+10 -2)
📝 frontend/rust-lib/flowy-database2/src/services/group/configuration.rs (+4 -0)
frontend/rust-lib/flowy-database2/src/services/group/controller_impls/date_controller.rs (+598 -0)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller_impls/mod.rs (+2 -0)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller_impls/select_option_controller/util.rs (+13 -1)
📝 frontend/rust-lib/flowy-database2/src/services/group/group_builder.rs (+13 -3)
frontend/rust-lib/flowy-database2/tests/database/group_test/date_group_test.rs (+208 -0)
📝 frontend/rust-lib/flowy-database2/tests/database/group_test/mod.rs (+1 -0)
📝 frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs (+26 -21)

📄 Description

https://github.com/AppFlowy-IO/AppFlowy/assets/3286303/47a98501-aebf-4856-a8ac-856ebc6e65ac

Feature Preview

resolves #1174

Currently, it defaults to group by date relative, Supporting group by date month, week, etc needs some changes in frontend which I think will be better to do in a separate PR alongside the hide_empty group config.


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2641 **Author:** [@zoli](https://github.com/zoli) **Created:** 5/28/2023 **Status:** ✅ Merged **Merged:** 8/14/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `feat/group-by-date-iss1174-develop` --- ### 📝 Commits (10+) - [`12077ad`](https://github.com/AppFlowy-IO/AppFlowy/commit/12077ad507047218ff9e7aae7b82b7b8ba0bbf64) feat: group by date - [`79a76cc`](https://github.com/AppFlowy-IO/AppFlowy/commit/79a76cce28d1fc3949d62efeb5801ffcda7374da) test: added more tests for group by date - [`0305cd8`](https://github.com/AppFlowy-IO/AppFlowy/commit/0305cd8109d223f58ad56dd0028320e04d1d94de) fix: print month in abbrev format - [`aca2612`](https://github.com/AppFlowy-IO/AppFlowy/commit/aca261233d243f6bfa25a685046320dd114123c1) chore: adapt group event changes - [`ffad056`](https://github.com/AppFlowy-IO/AppFlowy/commit/ffad05620b5d1d1091f89578279e291418b5306b) style: remove comment - [`2c6101d`](https://github.com/AppFlowy-IO/AppFlowy/commit/2c6101d1be06a9ebc1267ca93e072336e0dc58f7) fix: change date on changing group - [`0f8034d`](https://github.com/AppFlowy-IO/AppFlowy/commit/0f8034d1fbc12337decb7686df67d4d61805c5ee) chore: merge develop - [`4fba38f`](https://github.com/AppFlowy-IO/AppFlowy/commit/4fba38f42eac15505a8e912164cc941c56481185) fix: dont count time in relative group - [`25291ec`](https://github.com/AppFlowy-IO/AppFlowy/commit/25291ec04983ec1356a51f90d1b86e056a4594ed) chore: merge develop - [`0e723e9`](https://github.com/AppFlowy-IO/AppFlowy/commit/0e723e940da17811ce7c4bccf0dd881850689210) fix: check beginning of month is within 30 days ### 📊 Changes **12 files changed** (+891 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_info.dart` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/src/entities/group_entities/configuration.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option.rs` (+14 -12) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option_entities.rs` (+10 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/group/configuration.rs` (+4 -0) ➕ `frontend/rust-lib/flowy-database2/src/services/group/controller_impls/date_controller.rs` (+598 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller_impls/mod.rs` (+2 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller_impls/select_option_controller/util.rs` (+13 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/group/group_builder.rs` (+13 -3) ➕ `frontend/rust-lib/flowy-database2/tests/database/group_test/date_group_test.rs` (+208 -0) 📝 `frontend/rust-lib/flowy-database2/tests/database/group_test/mod.rs` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs` (+26 -21) </details> ### 📄 Description https://github.com/AppFlowy-IO/AppFlowy/assets/3286303/47a98501-aebf-4856-a8ac-856ebc6e65ac ### Feature Preview resolves #1174 Currently, it defaults to group by date relative, Supporting group by date month, week, etc needs some changes in frontend which I think will be better to do in a separate PR alongside the `hide_empty` group config. --- #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:18:19 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5344
No description provided.