[PR #7280] [CLOSED] fix: uri paste from Safari becoming blank pastes #7820

Closed
opened 2026-03-23 23:21:21 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7280
Author: @chrisirhc
Created: 1/24/2025
Status: Closed

Base: mainHead: chua/7214-uri-paste


📝 Commits (1)

  • b344f2d fix: uri paste from Safari becoming blank pastes

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/clipboard_service.dart (+6 -1)

📄 Description

Draft PR demonstrating issue and fix for part of #7214 :

Safari's (or GitHub) Share button -> Copy copies a rich text link that results in noop in the Appflowy when pasting. Workaround: tap in the address bar to copy and paste

This is a pretty hacky fix, but it demonstrates the issue where the uri type needs to be manually converted to html to be used by the paste. Otherwise, the paste results in a noop per the recording in #7214 .

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Fixes #7283


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7280 **Author:** [@chrisirhc](https://github.com/chrisirhc) **Created:** 1/24/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `chua/7214-uri-paste` --- ### 📝 Commits (1) - [`b344f2d`](https://github.com/AppFlowy-IO/AppFlowy/commit/b344f2d25108ed9482f27f3385ea4081eb947a82) fix: uri paste from Safari becoming blank pastes ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/clipboard_service.dart` (+6 -1) </details> ### 📄 Description Draft PR demonstrating issue and fix for part of #7214 : > Safari's (or GitHub) Share button -> Copy copies a rich text link that results in noop in the Appflowy when pasting. Workaround: tap in the address bar to copy and paste This is a pretty hacky fix, but it demonstrates the issue where the uri type needs to be manually converted to html to be used by the paste. Otherwise, the paste results in a noop [per the recording](https://github.com/user-attachments/assets/f5b05311-d5ad-4b50-9309-df5716cc2079) in #7214 . <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. Fixes #7283 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:21:21 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7820
No description provided.