[PR #5] [MERGED] Dotnet version compatibility #7

New issue

Closed

opened 2026-03-23 20:22:39 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 20:22:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/sectra-medical/SectraUrlLaunchSdk/pull/5
Author: @jonasstrandstedt
Created: 5/9/2025
Status: ✅ Merged
Merged: 5/9/2025
Merged by: @henziger

Base: main ← Head: dotnet-version-compatibility

📝 Commits (9)

4399cdb Change LangVersion in order to support .net 7 SDK
d81ff09 Fix .NET version compatibility issues
33a0de8 Function naming cleanup
22953fa Enhance compatibility in encryption
2750b57 Cleanup unused code
20e6d2e Add version compatibility tests using containers
13fb0ae Update GitHub CI pipeline
49ed428 Run integration tests in CI pipeline
e52c258 Update version numbers to 1.0.2

📊 Changes

30 files changed (+306 additions, -96 deletions)

View changed files

📝 .github/workflows/dotnet.yml (+7 -3)
📝 Directory.Build.props (+1 -1)
📝 README.md (+6 -0)
📝 SectraUrlLaunchSdk.sln (+13 -0)
➕ scripts/IntegrationTestRunner.sh (+59 -0)
➕ scripts/run-dotnet.sh (+20 -0)
📝 src/Pki/CHANGELOG.md (+6 -0)
📝 src/Pki/EncryptedUrlString.cs (+3 -3)
📝 src/Pki/Sectra.UrlLaunch.Pki.csproj (+3 -3)
📝 src/Pki/UrlStringEncryptor.cs (+2 -2)
📝 src/SharedSecret/AssemblyInfo.cs (+1 -0)
📝 src/SharedSecret/CHANGELOG.md (+6 -0)
➕ src/SharedSecret/DateTimeProvider.cs (+29 -0)
📝 src/SharedSecret/EncryptedOneTimeSignature.cs (+0 -13)
📝 src/SharedSecret/OneTimeSignature.cs (+3 -3)
📝 src/SharedSecret/Sectra.UrlLaunch.SharedSecret.csproj (+3 -3)
📝 src/SharedSecret/SymmetricEncryption.cs (+13 -41)
📝 src/UrlAccessString/CHANGELOG.md (+6 -0)
📝 src/UrlAccessString/QueryString.cs (+2 -2)
📝 src/UrlAccessString/Sectra.UrlLaunch.UrlAccessString.csproj (+4 -4)

...and 10 more files

📄 Description

Fixes compatibility issues between different .net versions. Also adds unit tests for backward compatibility.

Lowers target LangVersion to easier build and test compatibility for older .net versions.

Fixes #4

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sectra-medical/SectraUrlLaunchSdk/pull/5 **Author:** [@jonasstrandstedt](https://github.com/jonasstrandstedt) **Created:** 5/9/2025 **Status:** ✅ Merged **Merged:** 5/9/2025 **Merged by:** [@henziger](https://github.com/henziger) **Base:** `main` ← **Head:** `dotnet-version-compatibility` --- ### 📝 Commits (9) - [`4399cdb`](https://github.com/sectra-medical/SectraUrlLaunchSdk/commit/4399cdbe85e04d34c395aaefdb03ff7a15f4f402) Change LangVersion in order to support .net 7 SDK - [`d81ff09`](https://github.com/sectra-medical/SectraUrlLaunchSdk/commit/d81ff092da1947d02387942bab91616a9522dc7c) Fix .NET version compatibility issues - [`33a0de8`](https://github.com/sectra-medical/SectraUrlLaunchSdk/commit/33a0de8c4be63f76ce10f822a040d50f30e57ba4) Function naming cleanup - [`22953fa`](https://github.com/sectra-medical/SectraUrlLaunchSdk/commit/22953fae8ef94b8e9388e92b213be9e192bd1566) Enhance compatibility in encryption - [`2750b57`](https://github.com/sectra-medical/SectraUrlLaunchSdk/commit/2750b57cacaa2932f2caf25dc9c0ed25364b6e13) Cleanup unused code - [`20e6d2e`](https://github.com/sectra-medical/SectraUrlLaunchSdk/commit/20e6d2ed48369935ca04652a9303077a0e1e98dd) Add version compatibility tests using containers - [`13fb0ae`](https://github.com/sectra-medical/SectraUrlLaunchSdk/commit/13fb0aeb508c94ded575c61c07d6ea7044319100) Update GitHub CI pipeline - [`49ed428`](https://github.com/sectra-medical/SectraUrlLaunchSdk/commit/49ed42884c6e627b5d67562b1717ee59c59eec18) Run integration tests in CI pipeline - [`e52c258`](https://github.com/sectra-medical/SectraUrlLaunchSdk/commit/e52c258eaa3e3daf3a944447a42a1b22bcce80db) Update version numbers to 1.0.2 ### 📊 Changes **30 files changed** (+306 additions, -96 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/dotnet.yml` (+7 -3) 📝 `Directory.Build.props` (+1 -1) 📝 `README.md` (+6 -0) 📝 `SectraUrlLaunchSdk.sln` (+13 -0) ➕ `scripts/IntegrationTestRunner.sh` (+59 -0) ➕ `scripts/run-dotnet.sh` (+20 -0) 📝 `src/Pki/CHANGELOG.md` (+6 -0) 📝 `src/Pki/EncryptedUrlString.cs` (+3 -3) 📝 `src/Pki/Sectra.UrlLaunch.Pki.csproj` (+3 -3) 📝 `src/Pki/UrlStringEncryptor.cs` (+2 -2) 📝 `src/SharedSecret/AssemblyInfo.cs` (+1 -0) 📝 `src/SharedSecret/CHANGELOG.md` (+6 -0) ➕ `src/SharedSecret/DateTimeProvider.cs` (+29 -0) 📝 `src/SharedSecret/EncryptedOneTimeSignature.cs` (+0 -13) 📝 `src/SharedSecret/OneTimeSignature.cs` (+3 -3) 📝 `src/SharedSecret/Sectra.UrlLaunch.SharedSecret.csproj` (+3 -3) 📝 `src/SharedSecret/SymmetricEncryption.cs` (+13 -41) 📝 `src/UrlAccessString/CHANGELOG.md` (+6 -0) 📝 `src/UrlAccessString/QueryString.cs` (+2 -2) 📝 `src/UrlAccessString/Sectra.UrlLaunch.UrlAccessString.csproj` (+4 -4) _...and 10 more files_ </details> ### 📄 Description Fixes compatibility issues between different .net versions. Also adds unit tests for backward compatibility. Lowers target LangVersion to easier build and test compatibility for older .net versions. Fixes #4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

mirror

2026-03-23 20:22:39 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sectra-medical/archived-SectraUrlLaunchSdk#7

No description provided.

Rows
Columns