[PR #6] [MERGED] change "Tube Archivist IP" to "Tube Archivist URL" #41

New issue

Closed

opened 2026-03-23 20:32:12 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 20:32:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tubearchivist/browser-extension/pull/6
Author: @bakkot
Created: 10/27/2022
Status: ✅ Merged
Merged: 11/28/2022
Merged by: @bbilly1

Base: master ← Head: patch-1

📝 Commits (4)

d5f5557 change "Tube Archivist IP" to "Tube Archivist URL"
afbcb57 use full url
4ea141c typos
25dd6db fix it better

📊 Changes

3 files changed (+18 additions, -11 deletions)

View changed files

📝 extension/background.js (+1 -1)
📝 extension/index.html (+2 -4)
📝 extension/popup.js (+15 -6)

📄 Description

Saying "IP" is confusing when a.) it can be a domain name, not an IP and b.) it's supposed to include the HTTP part, not just a bare IP. (It's also documented as "URL" in the readme.)

Honestly it's a bit weird to have the protocol and domain in one place and the port in a different field. Is there a reason not to just have one field that expects something like http://tubearchivist.local:8000, i.e. a full URL as you'd have in the browser? I can make that change instead if you'd prefer.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tubearchivist/browser-extension/pull/6 **Author:** [@bakkot](https://github.com/bakkot) **Created:** 10/27/2022 **Status:** ✅ Merged **Merged:** 11/28/2022 **Merged by:** [@bbilly1](https://github.com/bbilly1) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (4) - [`d5f5557`](https://github.com/tubearchivist/browser-extension/commit/d5f5557e0603603616f7551342d051f8e8e3e027) change "Tube Archivist IP" to "Tube Archivist URL" - [`afbcb57`](https://github.com/tubearchivist/browser-extension/commit/afbcb5757e5208c835e752bceb38d7ae2dffa7b2) use full url - [`4ea141c`](https://github.com/tubearchivist/browser-extension/commit/4ea141c6fe2d602ebe83bf601f5300b9efcc40f5) typos - [`25dd6db`](https://github.com/tubearchivist/browser-extension/commit/25dd6dbdc553e05c65684716e243bb1d5cd35773) fix it better ### 📊 Changes **3 files changed** (+18 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `extension/background.js` (+1 -1) 📝 `extension/index.html` (+2 -4) 📝 `extension/popup.js` (+15 -6) </details> ### 📄 Description Saying "IP" is confusing when a.) it can be a domain name, not an IP and b.) it's supposed to include the HTTP part, not just a bare IP. (It's also documented as "URL" in the readme.) Honestly it's a bit weird to have the protocol and domain in one place and the port in a different field. Is there a reason not to just have one field that expects something like `http://tubearchivist.local:8000`, i.e. a full URL as you'd have in the browser? I can make that change instead if you'd prefer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>