[PR #11] [MERGED] fix port parsing logic #42

New issue

Closed

opened 2026-03-23 20:32:12 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 20:32:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tubearchivist/browser-extension/pull/11
Author: @bakkot
Created: 12/2/2022
Status: ✅ Merged
Merged: 12/2/2022
Merged by: @bbilly1

Base: master ← Head: protocol-has-colon

📝 Commits (1)

18bfa28 fix port parsing logic

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 extension/popup.js (+1 -1)

📄 Description

let url = new URL('https://example.com:443');
console.log(url.port); // empty string, because it's the default for the protocol
console.log(url.protocol); // 'https:' - note the colon, which was missing in the logic below

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tubearchivist/browser-extension/pull/11 **Author:** [@bakkot](https://github.com/bakkot) **Created:** 12/2/2022 **Status:** ✅ Merged **Merged:** 12/2/2022 **Merged by:** [@bbilly1](https://github.com/bbilly1) **Base:** `master` ← **Head:** `protocol-has-colon` --- ### 📝 Commits (1) - [`18bfa28`](https://github.com/tubearchivist/browser-extension/commit/18bfa28452caeeafbce5bb618d0dc4461e589f5b) fix port parsing logic ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `extension/popup.js` (+1 -1) </details> ### 📄 Description ```js let url = new URL('https://example.com:443'); console.log(url.port); // empty string, because it's the default for the protocol console.log(url.protocol); // 'https:' - note the colon, which was missing in the logic below ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>