[PR #30] [MERGED] Update subscribe button #50

New issue

Closed

opened 2026-03-23 20:32:15 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 20:32:15 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tubearchivist/browser-extension/pull/30
Author: @bakkot
Created: 11/3/2023
Status: ✅ Merged
Merged: 11/9/2023
Merged by: @bbilly1

Base: master ← Head: update-subscribe-button

📝 Commits (6)

c570aff Revert "delay buildChannelButton to account for UI refresh on YT"
72c94fb better logic for updating the subscribe button on page navigation
ee6db25 restore .eslintrc.js
75848ad fix infinite buttons
4f54e1f flip getChannelHandle logic, remove unvisible title containers
f8d69f5 implement extract video id on hover

📊 Changes

2 files changed (+101 additions, -54 deletions)

View changed files

📝 .eslintrc.js (+2 -0)
📝 extension/script.js (+99 -54)

📄 Description

Probably best to review the second commit individually; the first one is a git revert of github.com/tubearchivist/browser-extension@aaa04a43b5 so that the second one makes more sense.

The idea is that whenever the channelContainer element is updated (per a MutationObserver) we check to see if the handle has changed, and if so replace the subscribe/download buttons with new buttons.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tubearchivist/browser-extension/pull/30 **Author:** [@bakkot](https://github.com/bakkot) **Created:** 11/3/2023 **Status:** ✅ Merged **Merged:** 11/9/2023 **Merged by:** [@bbilly1](https://github.com/bbilly1) **Base:** `master` ← **Head:** `update-subscribe-button` --- ### 📝 Commits (6) - [`c570aff`](https://github.com/tubearchivist/browser-extension/commit/c570aff66df2c5e868b9ff55ebb9f6310241a94d) Revert "delay buildChannelButton to account for UI refresh on YT" - [`72c94fb`](https://github.com/tubearchivist/browser-extension/commit/72c94fbe99681f21e05b02a9eb7508327ac4e184) better logic for updating the subscribe button on page navigation - [`ee6db25`](https://github.com/tubearchivist/browser-extension/commit/ee6db2595fce1c5c2487c148072ca259d93c8f33) restore .eslintrc.js - [`75848ad`](https://github.com/tubearchivist/browser-extension/commit/75848ad4ebb3cbc51c7f1e18f2c2a8838a759730) fix infinite buttons - [`4f54e1f`](https://github.com/tubearchivist/browser-extension/commit/4f54e1f863f271cc10a52e5e2d4d6a33fe4524d6) flip getChannelHandle logic, remove unvisible title containers - [`f8d69f5`](https://github.com/tubearchivist/browser-extension/commit/f8d69f58830e178b3eb34e386e6adaee6298ec3f) implement extract video id on hover ### 📊 Changes **2 files changed** (+101 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+2 -0) 📝 `extension/script.js` (+99 -54) </details> ### 📄 Description Probably best to review the second commit individually; the first one is a `git revert` of https://github.com/tubearchivist/browser-extension/commit/aaa04a43b5eaf14f8763390a2f6065c0ac87d8dc so that the second one makes more sense. The idea is that whenever the `channelContainer` element is updated (per a MutationObserver) we check to see if the handle has changed, and if so replace the subscribe/download buttons with new buttons. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>