[PR #61] Correct typo in font URL which caused delays in opening the extension under certain circumstances #60

New issue

Open

opened 2026-03-23 20:32:19 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 20:32:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tubearchivist/browser-extension/pull/61
Author: @IAmABakuAMA
Created: 1/26/2026
Status: 🔄 Open

Base: master ← Head: patch-1

📝 Commits (1)

2b490a9 Correct typo in index.html

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 extension/index.html (+1 -1)

📄 Description

This is a minor change that should, hopefully, fix an annoying to track down bug, #48.

The index.html file attempts to call "googleapi.com". The correct URL is "googleapis.com". The extension appears to fallback to a different font upon the failure, however on some VPNs, the incorrect URL will get stuck loading for ~10-20 seconds before falling back.

In the future, some additional error handling logic could be implemented to time the font request out after a few seconds. Theoretically, the extension would get stuck opening indefinitely if the font domain is ever unreachable but does not return an outright failure, although the browser would probably forcefully time it out after a little while. The font could also be bundled or cached locally so that it doesn't need to be fetched locally.

Testing

I have been able to consistently reproduce #48 by using Windscribe VPN and Firefox on Windows 11. It is difficult to reproduce, as it seems to be caused by an old cached ip for that googleapi.com domain. Either way, this probably doesn't require extensive tests, as the typo domain is a (minor) issue either way. I did confirm that this resolves #48 for me by cloning the repo locally, changing the domain, and loading the extension in Firefox.

Note

I didn't use any linter or IDE to make this change. I just used GitHub's built in code editor in the web GUI. I know last time this caused an issue with the linter, apologies if that happens again.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tubearchivist/browser-extension/pull/61 **Author:** [@IAmABakuAMA](https://github.com/IAmABakuAMA) **Created:** 1/26/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`2b490a9`](https://github.com/tubearchivist/browser-extension/commit/2b490a9b3433ae210926f66bb52d1fcaf24633bb) Correct typo in index.html ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `extension/index.html` (+1 -1) </details> ### 📄 Description This is a minor change that should, hopefully, fix an annoying to track down bug, #48. The index.html file attempts to call "googleapi.com". The correct URL is "googleapis.com". The extension appears to fallback to a different font upon the failure, however on some VPNs, the incorrect URL will get stuck loading for ~10-20 seconds before falling back. In the future, some additional error handling logic could be implemented to time the font request out after a few seconds. Theoretically, the extension would get stuck opening indefinitely if the font domain is ever unreachable but does not return an outright failure, although the browser would probably forcefully time it out after a little while. The font could also be bundled or cached locally so that it doesn't need to be fetched locally. # Testing I have been able to consistently reproduce #48 by using Windscribe VPN and Firefox on Windows 11. It is difficult to reproduce, as it seems to be caused by an old cached ip for that googleapi.com domain. Either way, this probably doesn't require extensive tests, as the typo domain is a (minor) issue either way. I did confirm that this resolves #48 for me by cloning the repo locally, changing the domain, and loading the extension in Firefox. # Note I didn't use any linter or IDE to make this change. I just used GitHub's built in code editor in the web GUI. I know last time this caused an issue with the linter, apologies if that happens again. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>