[PR #31] [MERGED] Fix ArgumentNullException when channel has no tags #67

New issue

Closed

opened 2026-03-23 20:35:37 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 20:35:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tubearchivist/tubearchivist-jf-plugin/pull/31
Author: @AgentK20
Created: 12/1/2024
Status: ✅ Merged
Merged: 1/8/2025
Merged by: @DarkFighterLuke

Base: master ← Head: tag-nre-fix

📝 Commits (2)

6697f2b Correctly handle the possibility of a null-deserialized tags
5ff9611 Spacing

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 Jellyfin.Plugin.TubeArchivistMetadata/TubeArchivist/Channel/Channel.cs (+3 -1)

📄 Description

Fixes https://github.com/tubearchivist/tubearchivist-jf-plugin/issues/12.

As seen in the log lines below, some channels return a channel_tags of null:

{"channel_banner_url":"/cache/channels/UCuCkxoKLYO_EQ2GeFtbM_bw_banner.jpg","channel_description":"Education-y explainer videos that are almost good enough to watch.","channel_id":"UCuCkxoKLYO_EQ2GeFtbM_bw","channel_name":"Half as Interesting","channel_tags":null,"channel_thumb_url":"/cache/channels/UCuCkxoKLYO_EQ2GeFtbM_bw_thumb.jpg","channel_tvart_url":"/cache/channels/UCuCkxoKLYO_EQ2GeFtbM_bw_tvart.jpg"}

It looks like this was intended to be accounted for with the TagsJsonConverter, but my hunch is that it's not being invoked by the JSON deserializer because the value is null, so there's no object to convert.

This change adds a simple null check and, based on my local testing, successfully allows tubearchivist-jf-plugin to fetch channel metadata for channels with no tags.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tubearchivist/tubearchivist-jf-plugin/pull/31 **Author:** [@AgentK20](https://github.com/AgentK20) **Created:** 12/1/2024 **Status:** ✅ Merged **Merged:** 1/8/2025 **Merged by:** [@DarkFighterLuke](https://github.com/DarkFighterLuke) **Base:** `master` ← **Head:** `tag-nre-fix` --- ### 📝 Commits (2) - [`6697f2b`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/6697f2b4ccc89c4de311abd8809068e101d39a30) Correctly handle the possibility of a null-deserialized tags - [`5ff9611`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/5ff96113c82779afb4ee40dcade736adbc74ee5a) Spacing ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Plugin.TubeArchivistMetadata/TubeArchivist/Channel/Channel.cs` (+3 -1) </details> ### 📄 Description Fixes https://github.com/tubearchivist/tubearchivist-jf-plugin/issues/12. As seen in the log lines below, some channels return a channel_tags of null: ``` {"channel_banner_url":"/cache/channels/UCuCkxoKLYO_EQ2GeFtbM_bw_banner.jpg","channel_description":"Education-y explainer videos that are almost good enough to watch.","channel_id":"UCuCkxoKLYO_EQ2GeFtbM_bw","channel_name":"Half as Interesting","channel_tags":null,"channel_thumb_url":"/cache/channels/UCuCkxoKLYO_EQ2GeFtbM_bw_thumb.jpg","channel_tvart_url":"/cache/channels/UCuCkxoKLYO_EQ2GeFtbM_bw_tvart.jpg"} ``` It looks like this was intended to be accounted for with the `TagsJsonConverter`, but my hunch is that it's not being invoked by the JSON deserializer because the value is null, so there's no object to convert. This change adds a simple null check and, based on my local testing, successfully allows tubearchivist-jf-plugin to fetch channel metadata for channels with no tags. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>