[PR #38] [MERGED] Added new method for auth headers #69

New issue

Closed

opened 2026-03-23 20:35:38 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 20:35:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tubearchivist/tubearchivist-jf-plugin/pull/38
Author: @mattkduran
Created: 3/3/2025
Status: ✅ Merged
Merged: 3/10/2025
Merged by: @DarkFighterLuke

Base: master ← Head: master

📝 Commits (4)

c058a35 Added new method for auth headers
ebb2cdf Modified setter to allow for usernames with spaces
ddbbb4b Merge branch 'master' into master
76ac750 Fix UpdateAuthorizationHeader method

📊 Changes

2 files changed (+34 additions, -3 deletions)

View changed files

📝 Jellyfin.Plugin.TubeArchivistMetadata/Configuration/PluginConfiguration.cs (+15 -2)
📝 Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs (+19 -1)

📄 Description

PR for the below referenced issue

https://github.com/tubearchivist/tubearchivist-jf-plugin/issues/37

I'm not sure what tests are being done to validate any issues introduced by proposed changes -- are there any scripts needed to be ran after build?

Changes introduced:

Create a new method called UpdateAuthorizationHeader
- This checks if Configuration.TubeArchivistApiKey is not null. If this is not null, use the provided token as an api key for the authorization header and log a message indicating the header was created
- If this is null, log a message indicating that there is no api key configured
Replace the previous auth header setter with the new method
Add method call to plugin configuration file for the api key

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tubearchivist/tubearchivist-jf-plugin/pull/38 **Author:** [@mattkduran](https://github.com/mattkduran) **Created:** 3/3/2025 **Status:** ✅ Merged **Merged:** 3/10/2025 **Merged by:** [@DarkFighterLuke](https://github.com/DarkFighterLuke) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`c058a35`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/c058a35abe90d1387e59e2f7b9fe618e741bc04a) Added new method for auth headers - [`ebb2cdf`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/ebb2cdfcc61e7a1273f9a69b1e10ca23b8ac98dc) Modified setter to allow for usernames with spaces - [`ddbbb4b`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/ddbbb4ba25ba1e3e12dac56d422d7eeaf7c91f2a) Merge branch 'master' into master - [`76ac750`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/76ac750de283750dee91aba23f082cd0c7cf96ae) Fix UpdateAuthorizationHeader method ### 📊 Changes **2 files changed** (+34 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Plugin.TubeArchivistMetadata/Configuration/PluginConfiguration.cs` (+15 -2) 📝 `Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs` (+19 -1) </details> ### 📄 Description PR for the below referenced issue https://github.com/tubearchivist/tubearchivist-jf-plugin/issues/37 I'm not sure what tests are being done to validate any issues introduced by proposed changes -- are there any scripts needed to be ran after build? Changes introduced: - Create a new method called UpdateAuthorizationHeader - This checks if Configuration.TubeArchivistApiKey is not null. If this is not null, use the provided token as an api key for the authorization header and log a message indicating the header was created - If this is null, log a message indicating that there is no api key configured - Replace the previous auth header setter with the new method - Add method call to plugin configuration file for the api key --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>