mirror of
https://github.com/tubearchivist/tubearchivist-jf-plugin.git
synced 2026-03-23 20:37:14 +00:00
[PR #86] Normalize TubeArchivist URL resolution and redirect handling #85
Labels
No labels
bug
enhancement
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
tubearchivist/archived-tubearchivist-jf-plugin#85
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/tubearchivist/tubearchivist-jf-plugin/pull/86
Author: @cheahkhing
Created: 3/8/2026
Status: 🔄 Open
Base:
master← Head:master📝 Commits (4)
07eb39eInitial pland97eee6Fix TubeArchivist URL resolutionf0ce4ebRefine redirect handling follow-upsa449a9aMerge pull request #1 from cheahkhing/copilot/fix-issue-85📊 Changes
6 files changed (+86 additions, -45 deletions)
View changed files
📝
Jellyfin.Plugin.TubeArchivistMetadata/Providers/EpisodeImageProvider.cs(+1 -1)📝
Jellyfin.Plugin.TubeArchivistMetadata/Providers/EpisodeMetadataProvider.cs(+1 -1)📝
Jellyfin.Plugin.TubeArchivistMetadata/Providers/SeriesImageProvider.cs(+1 -1)📝
Jellyfin.Plugin.TubeArchivistMetadata/Providers/SeriesMetadataProvider.cs(+1 -1)📝
Jellyfin.Plugin.TubeArchivistMetadata/TubeArchivist/TubeArchivistApi.cs(+50 -41)📝
Jellyfin.Plugin.TubeArchivistMetadata/Utils/Utils.cs(+32 -0)📄 Description
This pull request refactors how URLs are constructed and handled throughout the TubeArchivist plugin, with a focus on robust URL resolution and improved handling of HTTP redirects. The main changes are the introduction of a new utility method for resolving URLs, consistent usage of this method across all HTTP requests, and centralized redirect handling logic.
URL Resolution and HTTP Request Handling:
Utils.ResolveUrlmethod to robustly resolve relative and absolute URLs against the configured TubeArchivist base URL, ensuring requests always target the correct host.EpisodeImageProvider,EpisodeMetadataProvider,SeriesImageProvider, andSeriesMetadataProviderto useUtils.ResolveUrlinstead of manual string concatenation and sanitization. [1] [2] [3] [4]Centralized Redirect Handling:
GetAsyncmethod inTubeArchivistApithat follows HTTP redirects up to a maximum count, logging each redirect and preventing infinite loops. All relevant API methods now use this method for GET requests. [1] [2]TubeArchivistApito use the new redirect-handling logic and URL resolution, replacing previous manual redirect handling. [1] [2] [3] [4] [5]🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.