mirror of
https://github.com/tubearchivist/tubearchivist-plex.git
synced 2026-03-23 20:37:11 +00:00
[GH-ISSUE #54] [Bug]: using an unstable build of TA breaks version checking #19
Labels
No labels
bug
bug
documentation
duplicate
enhancement
good first issue
help wanted
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
tubearchivist/archived-tubearchivist-plex#19
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Styloy on GitHub (Mar 22, 2024).
Original GitHub issue: https://github.com/tubearchivist/tubearchivist-plex/issues/54
I've read the documentation.
Operating System
TrueNAS (should be platform agnostic)
Your Bug Report
there is a parsing issue in test_ta_connection (in both scanner and agent), when using an unstable build of TA it chokes due to "-unstable" being appended in the response of /api/ping.
on my instance, I've changed the following as a quick and dirty fix. I can PR this if you feel this is suitable.
ta_version = [int(x) for x in response['version'][1:].split(".")]
to
ta_version = [int(x) for x in response['version'][1:].split(".").rstrip("-unstable")]
Relevant log output
Anything else?
No response
@lamusmaser commented on GitHub (Mar 22, 2024):
Noted. I did not test with Unstable, so I'll add that logic into the next release.
@lamusmaser commented on GitHub (May 9, 2024):
Incorporated fix into v0.1.5. This should no longer be an issue once that version is released.
@lamusmaser commented on GitHub (May 14, 2024):
v0.1.5 is now released and available. Closing until someone reports this as a continued issue.