AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 12:56:59 +00:00

[GH-ISSUE #3012] [FR] Add a tooltip to the theme mode button suggesting the shortcut for toggling theme #1319

New issue

Closed

opened 2026-03-23 20:47:48 +00:00 by mirror · 6 comments

mirror commented

2026-03-23 20:47:48 +00:00

Owner

Originally created by @MayurSMahajan on GitHub (Jul 16, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3012

Originally assigned to: @AdiAr11, @Codesbyusman on GitHub.

Description

We can toggle the theme mode of AppFlowy using the shortcut Ctrl+Shift+L or Cmd+Shift+L (on mac).
It would be nice if in the Settings, we informed the user about this shortcut through a tooltip.
This is where we can have the tooltip:

We want something like this:

Impact

Users who are not aware of the shortcut for toggling the theme mode will get to know about it.

Additional Context

Check out how the tooltip for Close Side Menu is implemented and solve the issue.
The shortcut suggested in the tooltip must check which OS the app is running on, since in the attached screenshot the app is running on Windows and the shortcut is suggesting to use Ctrl but on a Mac, it suggests using Cmd instead.

Originally created by @MayurSMahajan on GitHub (Jul 16, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3012 Originally assigned to: @AdiAr11, @Codesbyusman on GitHub. ### Description We can toggle the theme mode of AppFlowy using the shortcut `Ctrl+Shift+L` or `Cmd+Shift+L` (on mac). It would be nice if in the Settings, we informed the user about this shortcut through a tooltip. This is where we can have the tooltip: ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/47064215/a30cd6a5-29a7-4084-9333-efc518eb9f1c) We want something like this: ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/47064215/b8301b4f-f995-497c-820e-834f6399c8a0) ### Impact Users who are not aware of the shortcut for toggling the theme mode will get to know about it. ### Additional Context - Check out how the tooltip for Close Side Menu is implemented and solve the issue. - The shortcut suggested in the tooltip must check which OS the app is running on, since in the attached screenshot the app is running on Windows and the shortcut is suggesting to use `Ctrl` but on a Mac, it suggests using `Cmd` instead.

mirror

2026-03-23 20:47:48 +00:00

closed this issue
added the
good first issue for devs

improvements
labels

mirror commented

2026-03-23 20:47:49 +00:00

Author

Owner

@Codesbyusman commented on GitHub (Jul 16, 2023):

Hi,
I would like to work on it. Can I get some starting point for this?

@Codesbyusman commented on GitHub (Jul 16, 2023): Hi, I would like to work on it. Can I get some starting point for this?

mirror commented

2026-03-23 20:47:49 +00:00

Author

Owner

@MayurSMahajan commented on GitHub (Jul 16, 2023):

Great @Codesbyusman!
Here is something to help you get started quickly:

Find out where the Close Side bar option is implemented within the codebase.
There you can understand, how the tooltip is being shown.
Then you can apply the same type of implementation on the Theme Mode button. (for that you'll have to find the Theme Mode btn)

That's it.

@MayurSMahajan commented on GitHub (Jul 16, 2023): Great @Codesbyusman! Here is something to help you get started quickly: 1. Find out where the Close Side bar option is implemented within the codebase. 2. There you can understand, how the tooltip is being shown. 3. Then you can apply the same type of implementation on the Theme Mode button. (for that you'll have to find the Theme Mode btn) That's it.

mirror commented

2026-03-23 20:47:50 +00:00

Author

Owner

@AdiAr11 commented on GitHub (Jul 16, 2023):

Hi @Codesbyusman , if you decide not to work on this issue, please let me know and i would be happy to work on this.

@AdiAr11 commented on GitHub (Jul 16, 2023): Hi @Codesbyusman , if you decide not to work on this issue, please let me know and i would be happy to work on this.

mirror commented

2026-03-23 20:47:50 +00:00

Author

Owner

@Xazin commented on GitHub (Jul 16, 2023):

I would believe it to be best to wait before starting on this, for when this https://github.com/AppFlowy-IO/AppFlowy/pull/2848 has been merged.

Then the tooltip displayed can be with the dynamic hotkey instead of the static one. If they ended up changing it and then seeing the tooltip saying CTRL/CMD + SHIFT + L it could be confusing.

@Xazin commented on GitHub (Jul 16, 2023): I would believe it to be best to wait before starting on this, for when this https://github.com/AppFlowy-IO/AppFlowy/pull/2848 has been merged. Then the tooltip displayed can be with the dynamic hotkey instead of the static one. If they ended up changing it and then seeing the tooltip saying `CTRL/CMD + SHIFT + L` it could be confusing.

mirror commented

2026-03-23 20:47:50 +00:00

Author

Owner

@Codesbyusman commented on GitHub (Jul 16, 2023):

@Xazin I didn't look your comment earlier
@AdiAr11 we can do collectively but can wait till merge has been done as @Xazin said

@Codesbyusman commented on GitHub (Jul 16, 2023): @Xazin I didn't look your comment earlier @AdiAr11 we can do collectively but can wait till merge has been done as @Xazin said

mirror commented

2026-03-23 20:47:50 +00:00

Author

Owner

@AdiAr11 commented on GitHub (Jul 16, 2023):

@Codesbyusman Yes sure, i would be happy to work together !

@AdiAr11 commented on GitHub (Jul 16, 2023): @Codesbyusman Yes sure, i would be happy to work together !

mirror referenced this issue

2026-03-23 21:38:47 +00:00

[PR #1319] [MERGED] update image node selection style and fix the context menu display problem #4661