[PR #2096] Fix: #2028 auto enter edit mode for text field. #13505

New issue

Closed

opened 2026-03-24 21:46:40 +00:00 by mirror · 0 comments

mirror commented

2026-03-24 21:46:40 +00:00

Owner

Original Pull Request: https://github.com/AppFlowy-IO/AppFlowy/pull/2096

State: closed
Merged: Yes

Result

https://user-images.githubusercontent.com/73631606/227256009-4449cb19-f54b-4b07-90ff-a453d206ca07.mp4

Changes

Going through the code base I noticed that whenever popovermutex underwent a change, if the focus was already on the text field, it would then revoke the focus so that the focus shifts to the popover.
What this meant was however, that if focus is on textfield, it is unfocused, however no such request of focus was coming from the text field itself.
By adding a logical else block and requesting focus whenever mutex changes, we can ensure the focus defaults back to text field.

**Original Pull Request:** https://github.com/AppFlowy-IO/AppFlowy/pull/2096 **State:** closed **Merged:** Yes --- ## Result https://user-images.githubusercontent.com/73631606/227256009-4449cb19-f54b-4b07-90ff-a453d206ca07.mp4 ## Changes - Going through the code base I noticed that whenever popovermutex underwent a change, if the focus was already on the text field, it would then revoke the focus so that the focus shifts to the popover. - What this meant was however, that if focus is on textfield, it is unfocused, however no such request of focus was coming from the text field itself. - By adding a logical else block and requesting focus whenever mutex changes, we can ensure the focus defaults back to text field.

Rows
Columns