AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 12:56:59 +00:00

[GH-ISSUE #3351] [FR] have a shortcut for text alignment #1486

New issue

Closed

opened 2026-03-23 20:49:57 +00:00 by mirror · 11 comments

mirror commented

2026-03-23 20:49:57 +00:00

Owner

Originally created by @annieappflowy on GitHub (Sep 6, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3351

Originally assigned to: @Jayaprakash-dev on GitHub.

Description

have a shortcut for text alignment

Impact

Customers who frequently use text alignments in the editor

Additional Context

No response

Originally created by @annieappflowy on GitHub (Sep 6, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3351 Originally assigned to: @Jayaprakash-dev on GitHub. ### Description have a shortcut for text alignment ### Impact Customers who frequently use text alignments in the editor ### Additional Context _No response_

mirror

2026-03-23 20:49:58 +00:00

closed this issue
added the
good first issue for devs

hacktoberfest

2024

shortcuts

help wanted
labels

mirror commented

2026-03-23 20:49:59 +00:00

Author

Owner

@MayurSMahajan commented on GitHub (Sep 6, 2023):

Ideally the following are shortcuts for text alignment:
Ctrl+L : align left
Ctrl+R : align right
Ctrl+E : align center

Ctrl+E is already used to format code.
Also on the web, Ctrl+R refreshes the page in the browser.

So I propose we use a new set of shortcuts for text alignment:
Ctrl+Alt+L : align left
Ctrl+Alt+R : align right
Ctrl+Alt+E : align center

This way all our text alignment commands will be uniform and won't interfere with any existing commands.
cc @annieappflowy

@MayurSMahajan commented on GitHub (Sep 6, 2023): Ideally the following are shortcuts for text alignment: `Ctrl+L` : align left `Ctrl+R` : align right `Ctrl+E` : align center `Ctrl+E` is already used to format code. Also on the web, Ctrl+R refreshes the page in the browser. So I propose we use a new set of shortcuts for text alignment: `Ctrl+Alt+L` : align left `Ctrl+Alt+R` : align right `Ctrl+Alt+E` : align center This way all our text alignment commands will be uniform and won't interfere with any existing commands. cc @annieappflowy

mirror commented

2026-03-23 20:49:59 +00:00

Author

Owner

@sherazahmad720 commented on GitHub (Sep 10, 2023):

@annieappflowy can i work on this?

@sherazahmad720 commented on GitHub (Sep 10, 2023): @annieappflowy can i work on this?

mirror commented

2026-03-23 20:49:59 +00:00

Author

Owner

@MayurSMahajan commented on GitHub (Sep 10, 2023):

Sure! Thanks @sherazahmad720 for helping out.

@MayurSMahajan commented on GitHub (Sep 10, 2023): Sure! Thanks @sherazahmad720 for helping out.

mirror commented

2026-03-23 20:50:00 +00:00

Author

Owner

@Xazin commented on GitHub (Oct 25, 2023):

Hey @sherazahmad720, are you still working on this? Do you need help?

@Xazin commented on GitHub (Oct 25, 2023): Hey @sherazahmad720, are you still working on this? Do you need help?

mirror commented

2026-03-23 20:50:00 +00:00

Author

Owner

@sherazahmad720 commented on GitHub (Oct 25, 2023):

@Xazin Sorry i stuck somewhere if you want you can continue on this

@sherazahmad720 commented on GitHub (Oct 25, 2023): @Xazin Sorry i stuck somewhere if you want you can continue on this

mirror commented

2026-03-23 20:50:00 +00:00

Author

Owner

@annieappflowy commented on GitHub (Nov 5, 2023):

We could give you @sherazahmad720 more hints if you're keen to complete it.

@annieappflowy commented on GitHub (Nov 5, 2023): We could give you @sherazahmad720 more hints if you're keen to complete it.

mirror commented

2026-03-23 20:50:00 +00:00

Author

Owner

@Xazin commented on GitHub (Nov 5, 2023):

@Xazin Sorry i stuck somewhere if you want you can continue on this

If you still want a go, feel free to mention me on our discord and I will guide you.

@Xazin commented on GitHub (Nov 5, 2023): > @Xazin Sorry i stuck somewhere if you want you can continue on this If you still want a go, feel free to mention me on our discord and I will guide you.

mirror commented

2026-03-23 20:50:01 +00:00

Author

Owner

@Jayaprakash-dev commented on GitHub (Jan 5, 2024):

Hey @annieappflowy can I work on this?
I've already worked on it, and everything seems to be working smoothly.

One thing to note is that I haven't written a test for it yet. Would that be alright?

@Jayaprakash-dev commented on GitHub (Jan 5, 2024): Hey @annieappflowy can I work on this? I've already worked on it, and everything seems to be working smoothly. One thing to note is that I haven't written a test for it yet. Would that be alright?

mirror commented

2026-03-23 20:50:01 +00:00

Author

Owner

@Xazin commented on GitHub (Jan 5, 2024):

Hey @annieappflowy can I work on this? I've already worked on it, and everything seems to be working smoothly.

One thing to note is that I haven't written a test for it yet. Would that be alright?

Hey @Jayaprakash-dev , I've assigned you.

Do you need help with adding tests for it? Feel free to mention me on our Discord (I have the same handle as on github) if you need assistance.

@Xazin commented on GitHub (Jan 5, 2024): > Hey @annieappflowy can I work on this? I've already worked on it, and everything seems to be working smoothly. > > One thing to note is that I haven't written a test for it yet. Would that be alright? Hey @Jayaprakash-dev , I've assigned you. Do you need help with adding tests for it? Feel free to mention me on our Discord (I have the same handle as on github) if you need assistance.

mirror commented

2026-03-23 20:50:01 +00:00

Author

Owner

@Jayaprakash-dev commented on GitHub (Jan 5, 2024):

Hey @Xazin. Thanks for assigning it to me!

Sure I'll definitely reach out if I encounter any challenges. Could you provide a hint on where I should add the test in terms of the file or module? That would be super helpful.

@Jayaprakash-dev commented on GitHub (Jan 5, 2024): Hey @Xazin. Thanks for assigning it to me! Sure I'll definitely reach out if I encounter any challenges. Could you provide a hint on where I should add the test in terms of the file or module? That would be super helpful.

mirror commented

2026-03-23 20:50:01 +00:00

Author

Owner

@Xazin commented on GitHub (Jan 5, 2024):

Hey @Xazin. Thanks for assigning it to me!

Sure I'll definitely reach out if I encounter any challenges. Could you provide a hint on where I should add the test in terms of the file or module? That would be super helpful.

Sure thing!

You can add a test for the alignment shortcut in this file: appflowy_flutter/integration_test/document/document_alignment_test.dart- It currently holds the corresponding test for the toolbar. You can see how the expect is used, it should be similar to the test you will have to write.

@Xazin commented on GitHub (Jan 5, 2024): > Hey @Xazin. Thanks for assigning it to me! > > Sure I'll definitely reach out if I encounter any challenges. Could you provide a hint on where I should add the test in terms of the file or module? That would be super helpful. Sure thing! You can add a test for the alignment shortcut in this file: `appflowy_flutter/integration_test/document/document_alignment_test.dart`- It currently holds the corresponding test for the toolbar. You can see how the `expect` is used, it should be similar to the test you will have to write.

mirror referenced this issue

2026-03-23 22:15:44 +00:00

[PR #1486] [CLOSED] feat: add hover effect when trash icon is hovered or selected. #4769