[PR #1486] [CLOSED] feat: add hover effect when trash icon is hovered or selected. #4769

New issue

Closed

opened 2026-03-23 22:15:44 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:15:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1486
Author: @rasyidmi
Created: 11/25/2022
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (3)

dd40db0 feat: add hover effect when trash icon is hovered or selected.
5212dee build: merge code from main branch related to error on windows build.
7263ab2 revert: accidently pull a wrong branch.

📊 Changes

259 files changed (+2369 additions, -7737 deletions)

View changed files

📝 .github/workflows/ci.yaml (+2 -2)
📝 .github/workflows/dart_lint.yml (+2 -2)
📝 .github/workflows/dart_test.yml (+1 -1)
📝 .github/workflows/release.yml (+5 -26)
📝 .github/workflows/rust_lint.yml (+2 -2)
📝 CHANGELOG.md (+2 -17)
📝 frontend/.vscode/tasks.json (+1 -1)
📝 frontend/Makefile.toml (+1 -1)
📝 frontend/app_flowy/assets/translations/en.json (+1 -51)
📝 frontend/app_flowy/lib/plugins/blank/blank.dart (+2 -1)
📝 frontend/app_flowy/lib/plugins/board/application/board_bloc.dart (+25 -25)
📝 frontend/app_flowy/lib/plugins/board/application/board_data_controller.dart (+1 -1)
📝 frontend/app_flowy/lib/plugins/board/application/card/board_date_cell_bloc.dart (+2 -2)
📝 frontend/app_flowy/lib/plugins/board/application/card/card_bloc.dart (+6 -5)
📝 frontend/app_flowy/lib/plugins/board/application/group.dart (+8 -0)
📝 frontend/app_flowy/lib/plugins/board/presentation/board_page.dart (+3 -4)
➖ frontend/app_flowy/lib/plugins/board/presentation/card/board_checklist_cell.dart (+0 -35)
📝 frontend/app_flowy/lib/plugins/board/presentation/card/card_cell_builder.dart (+0 -6)
📝 frontend/app_flowy/lib/plugins/board/presentation/toolbar/board_setting.dart (+5 -1)
📝 frontend/app_flowy/lib/plugins/board/presentation/toolbar/board_toolbar.dart (+11 -16)

...and 80 more files

📄 Description

Hello AppFlowy. I am creating this PR to solve issue on this link.

Remove padding(horizontal: Insets.l), in line 103 so the hover effect width can match the container.
Add ValueListneableBuilder so MenuTrash widget can update their state when clicked or unclicked.

The video of the result is here

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1486 **Author:** [@rasyidmi](https://github.com/rasyidmi) **Created:** 11/25/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`dd40db0`](https://github.com/AppFlowy-IO/AppFlowy/commit/dd40db0a9c05c513cd2b6a9b9b0dfd17f0ab7c72) feat: add hover effect when trash icon is hovered or selected. - [`5212dee`](https://github.com/AppFlowy-IO/AppFlowy/commit/5212dee76d30617d4c6c8326aa17316f119a1316) build: merge code from main branch related to error on windows build. - [`7263ab2`](https://github.com/AppFlowy-IO/AppFlowy/commit/7263ab2ca8f03a83c23703e37627805adf116c86) revert: accidently pull a wrong branch. ### 📊 Changes **259 files changed** (+2369 additions, -7737 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yaml` (+2 -2) 📝 `.github/workflows/dart_lint.yml` (+2 -2) 📝 `.github/workflows/dart_test.yml` (+1 -1) 📝 `.github/workflows/release.yml` (+5 -26) 📝 `.github/workflows/rust_lint.yml` (+2 -2) 📝 `CHANGELOG.md` (+2 -17) 📝 `frontend/.vscode/tasks.json` (+1 -1) 📝 `frontend/Makefile.toml` (+1 -1) 📝 `frontend/app_flowy/assets/translations/en.json` (+1 -51) 📝 `frontend/app_flowy/lib/plugins/blank/blank.dart` (+2 -1) 📝 `frontend/app_flowy/lib/plugins/board/application/board_bloc.dart` (+25 -25) 📝 `frontend/app_flowy/lib/plugins/board/application/board_data_controller.dart` (+1 -1) 📝 `frontend/app_flowy/lib/plugins/board/application/card/board_date_cell_bloc.dart` (+2 -2) 📝 `frontend/app_flowy/lib/plugins/board/application/card/card_bloc.dart` (+6 -5) 📝 `frontend/app_flowy/lib/plugins/board/application/group.dart` (+8 -0) 📝 `frontend/app_flowy/lib/plugins/board/presentation/board_page.dart` (+3 -4) ➖ `frontend/app_flowy/lib/plugins/board/presentation/card/board_checklist_cell.dart` (+0 -35) 📝 `frontend/app_flowy/lib/plugins/board/presentation/card/card_cell_builder.dart` (+0 -6) 📝 `frontend/app_flowy/lib/plugins/board/presentation/toolbar/board_setting.dart` (+5 -1) 📝 `frontend/app_flowy/lib/plugins/board/presentation/toolbar/board_toolbar.dart` (+11 -16) _...and 80 more files_ </details> ### 📄 Description Hello AppFlowy. I am creating this PR to solve issue on this [link](https://github.com/AppFlowy-IO/AppFlowy/issues/834). 1. Remove `padding(horizontal: Insets.l),` in line 103 so the hover effect width can match the container. 2. Add `ValueListneableBuilder` so MenuTrash widget can update their state when clicked or unclicked. The video of the result is [here](https://drive.google.com/file/d/1qDIW75iBAvYm42zlHyRYxr7m-LSKSS1G/view?usp=share_link) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>