[GH-ISSUE #3480] [FR] apply a corner radius to the selection area. #1567

Closed
opened 2026-03-23 20:51:05 +00:00 by mirror · 19 comments
Owner

Originally created by @LucasXu0 on GitHub (Sep 20, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3480

Originally assigned to: @0xJaskeerat on GitHub.

Description

Screenshot 2023-09-20 at 22 39 57

Impact

It would appear more user-friendly with a corner radius.

Additional Context

No response

Originally created by @LucasXu0 on GitHub (Sep 20, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3480 Originally assigned to: @0xJaskeerat on GitHub. ### Description <img width="203" alt="Screenshot 2023-09-20 at 22 39 57" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/e6c51450-d303-494e-9935-2cf219972e87"> ### Impact It would appear more user-friendly with a corner radius. ### Additional Context _No response_
Author
Owner

@noelg-cj commented on GitHub (Sep 21, 2023):

Hey! I would like to take this fix

<!-- gh-comment-id:1730222827 --> @noelg-cj commented on GitHub (Sep 21, 2023): Hey! I would like to take this fix
Author
Owner

@Xazin commented on GitHub (Sep 21, 2023):

Hey! I would like to take this fix

Hi Noel, I've assigned you. Let us know if you need help or have any problems.

<!-- gh-comment-id:1730290071 --> @Xazin commented on GitHub (Sep 21, 2023): > Hey! I would like to take this fix Hi Noel, I've assigned you. Let us know if you need help or have any problems.
Author
Owner

@noelg-cj commented on GitHub (Sep 22, 2023):

Thanks!

<!-- gh-comment-id:1731041535 --> @noelg-cj commented on GitHub (Sep 22, 2023): Thanks!
Author
Owner

@Mandeep56Singh commented on GitHub (Oct 1, 2023):

are you still working on it

<!-- gh-comment-id:1742133766 --> @Mandeep56Singh commented on GitHub (Oct 1, 2023): are you still working on it
Author
Owner

@k22sumit commented on GitHub (Oct 4, 2023):

is this issue still open?

<!-- gh-comment-id:1747622343 --> @k22sumit commented on GitHub (Oct 4, 2023): is this issue still open?
Author
Owner

@0xJaskeerat commented on GitHub (Oct 5, 2023):

Hey @MayurSMahajan @Xazin @richardshiue , if @noelg-cj is not able to progress, can you please assign this to me so that I can try my hands on this

<!-- gh-comment-id:1748105519 --> @0xJaskeerat commented on GitHub (Oct 5, 2023): Hey @MayurSMahajan @Xazin @richardshiue , if @noelg-cj is not able to progress, can you please assign this to me so that I can try my hands on this
Author
Owner

@MayurSMahajan commented on GitHub (Oct 5, 2023):

Sure, since @noelg-cj hasn't contacted after two weeks. You can try your hands on it. Submit a PR directly, I won't be assigning you or anyone this issue.

<!-- gh-comment-id:1748112283 --> @MayurSMahajan commented on GitHub (Oct 5, 2023): Sure, since @noelg-cj hasn't contacted after two weeks. You can try your hands on it. Submit a PR directly, I won't be assigning you or anyone this issue.
Author
Owner

@0xJaskeerat commented on GitHub (Oct 5, 2023):

Sure, since @noelg-cj hasn't contacted after two weeks. You can try your hands on it. Submit a PR directly, I won't be assigning you or anyone this issue.

Cool so would love to discuss this first in detail , for what type of component is this issue for , can you @LucasXu0 give a lil more description and are you expecting the container of the arrow should have a corner radius ?

<!-- gh-comment-id:1748364013 --> @0xJaskeerat commented on GitHub (Oct 5, 2023): > Sure, since @noelg-cj hasn't contacted after two weeks. You can try your hands on it. Submit a PR directly, I won't be assigning you or anyone this issue. Cool so would love to discuss this first in detail , for what type of component is this issue for , can you @LucasXu0 give a lil more description and are you expecting the container of the arrow should have a corner radius ?
Author
Owner

@0xJaskeerat commented on GitHub (Oct 5, 2023):

@LucasXu0 @Xazin @MayurSMahajan Are you guys talking about this selection

Screenshot 2023-10-05 at 2 07 22 PM

The selection area , do you want to make it rounded from all corners ? , I guess in that case the padding would be required to beautify it otherwise it may look lil awful , anyways am open to discussion
Please list out what you guys think of this

<!-- gh-comment-id:1748386395 --> @0xJaskeerat commented on GitHub (Oct 5, 2023): @LucasXu0 @Xazin @MayurSMahajan Are you guys talking about this selection <img width="1440" alt="Screenshot 2023-10-05 at 2 07 22 PM" src="https://github.com/AppFlowy-IO/AppFlowy/assets/124770018/637f61eb-8bd8-423f-a76f-eb595cfc1509"> The selection area , do you want to make it rounded from all corners ? , I guess in that case the padding would be required to beautify it otherwise it may look lil awful , anyways am open to discussion Please list out what you guys think of this
Author
Owner

@0xJaskeerat commented on GitHub (Oct 9, 2023):

@LucasXu0 @Xazin @MayurSMahajan

@LucasXu0 @Xazin @MayurSMahajan Any updates guys ?

<!-- gh-comment-id:1753561036 --> @0xJaskeerat commented on GitHub (Oct 9, 2023): > @LucasXu0 @Xazin @MayurSMahajan @LucasXu0 @Xazin @MayurSMahajan Any updates guys ?
Author
Owner

@LucasXu0 commented on GitHub (Oct 13, 2023):

@0xJaskeerat Yes. The selection area.

Now
Screenshot 2023-10-13 at 10 08 15

Expected
Screenshot 2023-10-13 at 10 08 07

<!-- gh-comment-id:1760658788 --> @LucasXu0 commented on GitHub (Oct 13, 2023): @0xJaskeerat Yes. The selection area. Now <img width="30" alt="Screenshot 2023-10-13 at 10 08 15" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/ce5019da-5b5b-4b30-b9ad-92b166196c6a"> Expected <img width="44" alt="Screenshot 2023-10-13 at 10 08 07" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/97ca184b-ea58-4abb-bc8d-263780515130">
Author
Owner

@ShivamMenda commented on GitHub (Oct 13, 2023):

@LucasXu0 If this issue is still open can I take it up?

<!-- gh-comment-id:1762039197 --> @ShivamMenda commented on GitHub (Oct 13, 2023): @LucasXu0 If this issue is still open can I take it up?
Author
Owner

@zaidhussain2k6 commented on GitHub (Oct 15, 2023):

Please Assign it to me #3480

<!-- gh-comment-id:1763440323 --> @zaidhussain2k6 commented on GitHub (Oct 15, 2023): Please Assign it to me #3480
Author
Owner

@ekakshjanweja commented on GitHub (Oct 16, 2023):

@LucasXu0 is any one working on this?

<!-- gh-comment-id:1764708900 --> @ekakshjanweja commented on GitHub (Oct 16, 2023): @LucasXu0 is any one working on this?
Author
Owner

@0xJaskeerat commented on GitHub (Oct 16, 2023):

Hey yes am working on this @ekakshjanweja

<!-- gh-comment-id:1764728148 --> @0xJaskeerat commented on GitHub (Oct 16, 2023): Hey yes am working on this @ekakshjanweja
Author
Owner

@SharmaDhruv2511 commented on GitHub (Oct 24, 2023):

Hi @LucasXu0 I want to work on this issue. Can you please assign me??

<!-- gh-comment-id:1776904082 --> @SharmaDhruv2511 commented on GitHub (Oct 24, 2023): Hi @LucasXu0 I want to work on this issue. Can you please assign me??
Author
Owner

@Xazin commented on GitHub (Oct 25, 2023):

Hey everyone, I've assigned this issue to me for now.

@0xJaskeerat If you still want to submit the PR for this, please hit me up on our discord, and I'll guide you through the implementation. Otherwise I'll have to pick someone else :)

<!-- gh-comment-id:1779807746 --> @Xazin commented on GitHub (Oct 25, 2023): Hey everyone, I've assigned this issue to me for now. @0xJaskeerat If you still want to submit the PR for this, please hit me up on our discord, and I'll guide you through the implementation. Otherwise I'll have to pick someone else :)
Author
Owner

@0xJaskeerat commented on GitHub (Oct 25, 2023):

@Xazin Hey everyone, I've assigned this issue to me for now.

@0xJaskeerat If you still want to submit the PR for this, please hit me up on our discord, and I'll guide you through the implementation. Otherwise I'll have to pick someone else :)

Hey I still wish to work on this , as I have been banging my head to find a fix for this

I didn't knew this was supposed to be for a different repo , was thinking it belonged to Appflowy repo only
@richardshiue told me about this

Also I have dm'ed you on discord . Username : jas.chill

<!-- gh-comment-id:1779826473 --> @0xJaskeerat commented on GitHub (Oct 25, 2023): > @Xazin Hey everyone, I've assigned this issue to me for now. > > @0xJaskeerat If you still want to submit the PR for this, please hit me up on our discord, and I'll guide you through the implementation. Otherwise I'll have to pick someone else :) Hey I still wish to work on this , as I have been banging my head to find a fix for this I didn't knew this was supposed to be for a different repo , was thinking it belonged to Appflowy repo only @richardshiue told me about this Also I have dm'ed you on discord . Username : jas.chill
Author
Owner

@0xJaskeerat commented on GitHub (Oct 27, 2023):

Hey @Xazin @LucasXu0 @richardshiue

Checkout and review this PR to this issue
https://github.com/AppFlowy-IO/appflowy-editor/pull/556

<!-- gh-comment-id:1783173654 --> @0xJaskeerat commented on GitHub (Oct 27, 2023): Hey @Xazin @LucasXu0 @richardshiue Checkout and review this PR to this issue https://github.com/AppFlowy-IO/appflowy-editor/pull/556
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#1567
No description provided.