[PR #1567] [MERGED] refactor: appflowy themes #4825

New issue

Closed

opened 2026-03-23 22:16:00 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1567
Author: @richardshiue
Created: 12/11/2022
Status: ✅ Merged
Merged: 12/18/2022
Merged by: @appflowy

Base: main ← Head: refactor-appearancesettingscubit

📝 Commits (4)

647c8ad refactor: appflowy themes
b57e3c7 refactor: store ThemeData directly in cubit
2da5e11 refactor: remove textStyles
ca815a3 refactor: move AppTheme back into cubit

📊 Changes

7 files changed (+398 additions, -376 deletions)

View changed files

📝 frontend/app_flowy/lib/startup/tasks/app_widget.dart (+2 -2)
📝 frontend/app_flowy/lib/workspace/application/appearance.dart (+205 -49)
➕ frontend/app_flowy/packages/flowy_infra/lib/colorscheme/colorscheme.dart (+83 -0)
➕ frontend/app_flowy/packages/flowy_infra/lib/colorscheme/default_colorscheme.dart (+74 -0)
➖ frontend/app_flowy/packages/flowy_infra/lib/text_style.dart (+0 -64)
📝 frontend/app_flowy/packages/flowy_infra/lib/theme.dart (+30 -260)
📝 frontend/app_flowy/test/bloc_test/app_setting_test/appearance_test.dart (+4 -1)

📄 Description

reduce responsibility of AppTheme to only contain colorscheme (and theme metadata in the future). I've moved the font family and the getThemeData function out of the class.
make the colorscheme more easily extendable

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1567 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 12/11/2022 **Status:** ✅ Merged **Merged:** 12/18/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `refactor-appearancesettingscubit` --- ### 📝 Commits (4) - [`647c8ad`](https://github.com/AppFlowy-IO/AppFlowy/commit/647c8ad6807c9c4aa774de44333614df685836e8) refactor: appflowy themes - [`b57e3c7`](https://github.com/AppFlowy-IO/AppFlowy/commit/b57e3c7aca41963bfaf658d252c33d976510f151) refactor: store ThemeData directly in cubit - [`2da5e11`](https://github.com/AppFlowy-IO/AppFlowy/commit/2da5e112eb4d0bac883c76f152afe267097e9432) refactor: remove textStyles - [`ca815a3`](https://github.com/AppFlowy-IO/AppFlowy/commit/ca815a324017ade184ec00a6e64a67003bb63e22) refactor: move AppTheme back into cubit ### 📊 Changes **7 files changed** (+398 additions, -376 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/startup/tasks/app_widget.dart` (+2 -2) 📝 `frontend/app_flowy/lib/workspace/application/appearance.dart` (+205 -49) ➕ `frontend/app_flowy/packages/flowy_infra/lib/colorscheme/colorscheme.dart` (+83 -0) ➕ `frontend/app_flowy/packages/flowy_infra/lib/colorscheme/default_colorscheme.dart` (+74 -0) ➖ `frontend/app_flowy/packages/flowy_infra/lib/text_style.dart` (+0 -64) 📝 `frontend/app_flowy/packages/flowy_infra/lib/theme.dart` (+30 -260) 📝 `frontend/app_flowy/test/bloc_test/app_setting_test/appearance_test.dart` (+4 -1) </details> ### 📄 Description - reduce responsibility of AppTheme to only contain colorscheme (and theme metadata in the future). I've moved the font family and the getThemeData function out of the class. - make the colorscheme more easily extendable --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>