[GH-ISSUE #834] [FR] Add hover and selected state of Trash #337

Closed
opened 2026-03-23 20:35:35 +00:00 by mirror · 8 comments
Owner

Originally created by @vincentdchan on GitHub (Aug 12, 2022).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/834

Originally assigned to: @rasyidmi on GitHub.

When the Trash tab is selected, there is no hover state.

image

Expect:

Add hover and selected background of Trash corresponding to the item of the panel:

image
Originally created by @vincentdchan on GitHub (Aug 12, 2022). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/834 Originally assigned to: @rasyidmi on GitHub. When the Trash tab is selected, there is no hover state. <img width="342" alt="image" src="https://user-images.githubusercontent.com/2352832/184302822-2aa1b648-3d63-458e-80a8-f29bd36152a3.png"> **Expect:** Add hover and selected background of Trash corresponding to the item of the panel: <img width="314" alt="image" src="https://user-images.githubusercontent.com/2352832/184303025-8b5359ba-cdc6-4221-ae08-730e236625a1.png">
Author
Owner

@IMPranshu commented on GitHub (Aug 22, 2022):

Please assign this to me.

<!-- gh-comment-id:1221843022 --> @IMPranshu commented on GitHub (Aug 22, 2022): Please assign this to me.
Author
Owner

@rasyidmi commented on GitHub (Nov 18, 2022):

I am interested in solving this issue. Can you assign me? @vincentdchan

<!-- gh-comment-id:1319565717 --> @rasyidmi commented on GitHub (Nov 18, 2022): I am interested in solving this issue. Can you assign me? @vincentdchan
Author
Owner

@richardshiue commented on GitHub (Nov 22, 2022):

Hello @IMPranshu, have you made any progress on this? If not, @rasyidmi would like to take a crack at it

<!-- gh-comment-id:1323047358 --> @richardshiue commented on GitHub (Nov 22, 2022): Hello @IMPranshu, have you made any progress on this? If not, @rasyidmi would like to take a crack at it
Author
Owner

@rasyidmi commented on GitHub (Nov 25, 2022):

Hello @richardshiue, I have written my code and the video of the result is here

Can you assign me so you can review it?

Thank you.

<!-- gh-comment-id:1327653989 --> @rasyidmi commented on GitHub (Nov 25, 2022): Hello @richardshiue, I have written my code and the video of the result is [here](https://drive.google.com/file/d/1qDIW75iBAvYm42zlHyRYxr7m-LSKSS1G/view?usp=share_link) Can you assign me so you can review it? Thank you.
Author
Owner

@rasyidmi commented on GitHub (Nov 25, 2022):

This is the link for my commit

commit link

<!-- gh-comment-id:1327663900 --> @rasyidmi commented on GitHub (Nov 25, 2022): This is the link for my commit [commit link](https://github.com/rasyidmi/AppFlowy/commit/dd40db0a9c05c513cd2b6a9b9b0dfd17f0ab7c72)
Author
Owner

@richardshiue commented on GitHub (Nov 25, 2022):

Got it, thanks for working on this! I've assigned the issue to you

<!-- gh-comment-id:1327685848 --> @richardshiue commented on GitHub (Nov 25, 2022): Got it, thanks for working on this! I've assigned the issue to you
Author
Owner

@rasyidmi commented on GitHub (Nov 25, 2022):

Got it, thanks for working on this! I've assigned the issue to you

Thank you @richardshiue can't wait for the review😄

<!-- gh-comment-id:1327687943 --> @rasyidmi commented on GitHub (Nov 25, 2022): > Got it, thanks for working on this! I've assigned the issue to you Thank you @richardshiue can't wait for the review😄
Author
Owner

@richardshiue commented on GitHub (Jan 4, 2023):

With #1513 merged, this task is complete!

<!-- gh-comment-id:1370518463 --> @richardshiue commented on GitHub (Jan 4, 2023): With #1513 merged, this task is complete!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#337
No description provided.