[PR #21] [MERGED] #19 - [FR] Successfully to build workable version for windows (Rust t… #3946

Closed
opened 2026-03-23 21:35:37 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/21
Author: @pdckxd
Created: 11/17/2021
Status: Merged
Merged: 11/17/2021
Merged by: @appflowy

Base: mainHead: main


📝 Commits (1)

  • 5ee3797 #19 - [FR] Successfully to build workable version for windows (Rust target: x86_64-pc-windows-msvc), request to contribute

📊 Changes

7 files changed (+212 additions, -13 deletions)

View changed files

doc/BUILD_ON_WNIDOWS.md (+56 -0)
📝 scripts/flowy-tool/Cargo.toml (+1 -1)
📝 scripts/flowy-tool/src/proto/proto_gen.rs (+1 -4)
📝 scripts/flowy-tool/src/util/file.rs (+6 -1)
📝 scripts/makefile/env.toml (+86 -5)
📝 scripts/makefile/flutter.toml (+24 -2)
📝 scripts/makefile/protobuf.toml (+38 -0)

📄 Description

For issue #19

  1. scripts\flowy-tool\Cargo.toml
  • Remove shell dependency which does not support windows
  1. scripts\makefile\env.toml
  • Enhance environment checking for building app on windows
  1. scripts\flowy-tool\src\util\file.rs
  • Trim unnecessary prefix "\?" for std::fs::canonicalize(root) on windows
  1. scripts\makefile\flutter.toml
  • add dependency for "tasks.appflowy-windows" to copy dart_ffi.dll from rust build folder to flutter build folder
  1. scripts\flowy-tool\src\proto\proto_gen.rs
  • Remove dir by using platform independent code rather than calling *nix shell command
  1. scripts\makefile\protobuf.toml
  • tasks.gen_dart_event: call duckscript to gen_dart_event on windows platform

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/21 **Author:** [@pdckxd](https://github.com/pdckxd) **Created:** 11/17/2021 **Status:** ✅ Merged **Merged:** 11/17/2021 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`5ee3797`](https://github.com/AppFlowy-IO/AppFlowy/commit/5ee37972efb976fa18ea6b6c63a18194503a05c8) #19 - [FR] Successfully to build workable version for windows (Rust target: x86_64-pc-windows-msvc), request to contribute ### 📊 Changes **7 files changed** (+212 additions, -13 deletions) <details> <summary>View changed files</summary> ➕ `doc/BUILD_ON_WNIDOWS.md` (+56 -0) 📝 `scripts/flowy-tool/Cargo.toml` (+1 -1) 📝 `scripts/flowy-tool/src/proto/proto_gen.rs` (+1 -4) 📝 `scripts/flowy-tool/src/util/file.rs` (+6 -1) 📝 `scripts/makefile/env.toml` (+86 -5) 📝 `scripts/makefile/flutter.toml` (+24 -2) 📝 `scripts/makefile/protobuf.toml` (+38 -0) </details> ### 📄 Description For issue #19 1. scripts\flowy-tool\Cargo.toml - Remove shell dependency which does not support windows 2. scripts\makefile\env.toml - Enhance environment checking for building app on windows 3. scripts\flowy-tool\src\util\file.rs - Trim unnecessary prefix "\\?\" for std::fs::canonicalize(root) on windows 4. scripts\makefile\flutter.toml - add dependency for "tasks.appflowy-windows" to copy dart_ffi.dll from rust build folder to flutter build folder 5. scripts\flowy-tool\src\proto\proto_gen.rs - Remove dir by using platform independent code rather than calling *nix shell command 6. scripts\makefile\protobuf.toml - tasks.gen_dart_event: call duckscript to gen_dart_event on windows platform --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 21:35:37 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#3946
No description provided.