[PR #3946] [MERGED] chore: update Russian, fix naming conventions and typos #5964

Closed
opened 2026-03-23 22:21:06 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3946
Author: @Emilkyo
Created: 11/16/2023
Status: Merged
Merged: 11/17/2023
Merged by: @LucasXu0

Base: mainHead: chore/fix-naming-conventions-and-typos


📝 Commits (2)

  • e47c946 chore: typos fix
  • 60163aa chore: compliance with naming conventions

📊 Changes

28 files changed (+146 additions, -102 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart (+1 -1)
📝 frontend/resources/translations/am-ET.json (+2 -2)
📝 frontend/resources/translations/ar-SA.json (+1 -1)
📝 frontend/resources/translations/ca-ES.json (+1 -1)
📝 frontend/resources/translations/de-DE.json (+1 -1)
📝 frontend/resources/translations/en.json (+1 -1)
📝 frontend/resources/translations/es-VE.json (+1 -1)
📝 frontend/resources/translations/eu-ES.json (+1 -1)
📝 frontend/resources/translations/fa.json (+1 -1)
📝 frontend/resources/translations/fr-CA.json (+1 -1)
📝 frontend/resources/translations/fr-FR.json (+1 -1)
📝 frontend/resources/translations/hin.json (+1 -1)
📝 frontend/resources/translations/hu-HU.json (+1 -1)
📝 frontend/resources/translations/id-ID.json (+2 -3)
📝 frontend/resources/translations/it-IT.json (+1 -1)
📝 frontend/resources/translations/ja-JP.json (+1 -1)
📝 frontend/resources/translations/ko-KR.json (+1 -1)
📝 frontend/resources/translations/pl-PL.json (+1 -1)
📝 frontend/resources/translations/pt-BR.json (+1 -1)
📝 frontend/resources/translations/pt-PT.json (+2 -2)

...and 8 more files

📄 Description

Sorry, I’m just learning to contribute. :)

I didn't understand why snake_case is used for the variable create_new_card and not lowerCamelCase.
So I decided it was a typo and corrected it.

🤦🏼‍♂️ And I also added part of Russian translation from prev PR, excuse the inaccuracy 😿

Please pay attention!

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3946 **Author:** [@Emilkyo](https://github.com/Emilkyo) **Created:** 11/16/2023 **Status:** ✅ Merged **Merged:** 11/17/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `chore/fix-naming-conventions-and-typos` --- ### 📝 Commits (2) - [`e47c946`](https://github.com/AppFlowy-IO/AppFlowy/commit/e47c94647bb62ea2f9fdb47873911c8465917c03) chore: typos fix - [`60163aa`](https://github.com/AppFlowy-IO/AppFlowy/commit/60163aa528503bd1aed84c436a10d5eee254f668) chore: compliance with naming conventions ### 📊 Changes **28 files changed** (+146 additions, -102 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart` (+1 -1) 📝 `frontend/resources/translations/am-ET.json` (+2 -2) 📝 `frontend/resources/translations/ar-SA.json` (+1 -1) 📝 `frontend/resources/translations/ca-ES.json` (+1 -1) 📝 `frontend/resources/translations/de-DE.json` (+1 -1) 📝 `frontend/resources/translations/en.json` (+1 -1) 📝 `frontend/resources/translations/es-VE.json` (+1 -1) 📝 `frontend/resources/translations/eu-ES.json` (+1 -1) 📝 `frontend/resources/translations/fa.json` (+1 -1) 📝 `frontend/resources/translations/fr-CA.json` (+1 -1) 📝 `frontend/resources/translations/fr-FR.json` (+1 -1) 📝 `frontend/resources/translations/hin.json` (+1 -1) 📝 `frontend/resources/translations/hu-HU.json` (+1 -1) 📝 `frontend/resources/translations/id-ID.json` (+2 -3) 📝 `frontend/resources/translations/it-IT.json` (+1 -1) 📝 `frontend/resources/translations/ja-JP.json` (+1 -1) 📝 `frontend/resources/translations/ko-KR.json` (+1 -1) 📝 `frontend/resources/translations/pl-PL.json` (+1 -1) 📝 `frontend/resources/translations/pt-BR.json` (+1 -1) 📝 `frontend/resources/translations/pt-PT.json` (+2 -2) _...and 8 more files_ </details> ### 📄 Description Sorry, I’m just learning to contribute. :) I didn't understand why **snake_case** is used for the variable `create_new_card` and not **lowerCamelCase**. So I decided it was a typo and corrected it. 🤦🏼‍♂️ And I also added **part** of Russian translation from [prev PR](https://github.com/AppFlowy-IO/AppFlowy/pull/3933), excuse the inaccuracy 😿 Please pay attention! #### PR Checklist - [X] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [X] I've listed at least one issue that this PR fixes in the description above. - [X] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [X] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:06 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5964
No description provided.