[PR #590] [MERGED] Add workspace settings #4218

New issue

Closed

opened 2026-03-23 21:36:50 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:36:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/590
Author: @ENsu
Created: 7/5/2022
Status: ✅ Merged
Merged: 7/22/2022
Merged by: @appflowy

Base: main ← Head: add_workspace_settings

📝 Commits (10+)

0d216e5 Merge branch 'main' into add_workspace_settings
8252450 Merge branch 'main' of https://github.com/AppFlowy-IO/appflowy into add_workspace_settings
51ab1b6 feat: add widget to update username
f24e154 refactor: create SettingsUserViewBloc
db165f7 refactor: remove updateUserName from MenuUserBloc
29ce171 feat: show name on _UserNameInput
a8b560e debug: rerender username properly
da80efe feat: add SettingDialogBloc
89644e8 Merge branch 'main' into add_workspace_settings
1a88797 fix: fix merge from main

📊 Changes

10 files changed (+283 additions, -56 deletions)

View changed files

📝 frontend/app_flowy/assets/translations/en.json (+1 -0)
📝 frontend/app_flowy/lib/startup/deps_resolver.dart (+12 -0)
➕ frontend/app_flowy/lib/workspace/application/settings/prelude.dart (+1 -0)
➕ frontend/app_flowy/lib/workspace/application/settings/settings_dialog_bloc.dart (+67 -0)
➕ frontend/app_flowy/lib/workspace/application/user/prelude.dart (+1 -0)
➕ frontend/app_flowy/lib/workspace/application/user/settings_user_bloc.dart (+79 -0)
📝 frontend/app_flowy/lib/workspace/presentation/home/menu/menu_user.dart (+2 -1)
📝 frontend/app_flowy/lib/workspace/presentation/settings/settings_dialog.dart (+60 -55)
📝 frontend/app_flowy/lib/workspace/presentation/settings/widgets/settings_menu.dart (+10 -0)
➕ frontend/app_flowy/lib/workspace/presentation/settings/widgets/settings_user_view.dart (+50 -0)

📄 Description

There are 3 things I would like to mention:

I'm currently using Notions' naming convention, settings. This results in the newly created view SettingsSettingsView, which I'm not sure is a good name.
Notion:

AppFlowy:
I need to pass UserProfile user all the way down into the widget; I hope this is correct.
I have not yet implemented the icon section; I will do so later.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/590 **Author:** [@ENsu](https://github.com/ENsu) **Created:** 7/5/2022 **Status:** ✅ Merged **Merged:** 7/22/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `add_workspace_settings` --- ### 📝 Commits (10+) - [`0d216e5`](https://github.com/AppFlowy-IO/AppFlowy/commit/0d216e56479d5c8f4d30f2275537dafe1c18e1ff) Merge branch 'main' into add_workspace_settings - [`8252450`](https://github.com/AppFlowy-IO/AppFlowy/commit/8252450a447aeca6ae46a166ac9ed84fbce7923f) Merge branch 'main' of https://github.com/AppFlowy-IO/appflowy into add_workspace_settings - [`51ab1b6`](https://github.com/AppFlowy-IO/AppFlowy/commit/51ab1b6798f0aa10de413e27b44404fa3e49df84) feat: add widget to update username - [`f24e154`](https://github.com/AppFlowy-IO/AppFlowy/commit/f24e154b4fb5cb4776040c945c9fc5e89ef4d085) refactor: create SettingsUserViewBloc - [`db165f7`](https://github.com/AppFlowy-IO/AppFlowy/commit/db165f70061433f291170f4d4cd406593cd0a285) refactor: remove updateUserName from MenuUserBloc - [`29ce171`](https://github.com/AppFlowy-IO/AppFlowy/commit/29ce17178375e3f19b5ca65d8313aa5bc6fbf059) feat: show name on _UserNameInput - [`a8b560e`](https://github.com/AppFlowy-IO/AppFlowy/commit/a8b560ed935820e7a3df75c6c4998db73182e701) debug: rerender username properly - [`da80efe`](https://github.com/AppFlowy-IO/AppFlowy/commit/da80efecd17b320b3c7f6c730b1110ed590e49e7) feat: add SettingDialogBloc - [`89644e8`](https://github.com/AppFlowy-IO/AppFlowy/commit/89644e88daadb4d4473ba91c34007e120abf87ad) Merge branch 'main' into add_workspace_settings - [`1a88797`](https://github.com/AppFlowy-IO/AppFlowy/commit/1a887979c4991db4fc2ae95c91327debb8b50015) fix: fix merge from main ### 📊 Changes **10 files changed** (+283 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/assets/translations/en.json` (+1 -0) 📝 `frontend/app_flowy/lib/startup/deps_resolver.dart` (+12 -0) ➕ `frontend/app_flowy/lib/workspace/application/settings/prelude.dart` (+1 -0) ➕ `frontend/app_flowy/lib/workspace/application/settings/settings_dialog_bloc.dart` (+67 -0) ➕ `frontend/app_flowy/lib/workspace/application/user/prelude.dart` (+1 -0) ➕ `frontend/app_flowy/lib/workspace/application/user/settings_user_bloc.dart` (+79 -0) 📝 `frontend/app_flowy/lib/workspace/presentation/home/menu/menu_user.dart` (+2 -1) 📝 `frontend/app_flowy/lib/workspace/presentation/settings/settings_dialog.dart` (+60 -55) 📝 `frontend/app_flowy/lib/workspace/presentation/settings/widgets/settings_menu.dart` (+10 -0) ➕ `frontend/app_flowy/lib/workspace/presentation/settings/widgets/settings_user_view.dart` (+50 -0) </details> ### 📄 Description There are 3 things I would like to mention: 1. I'm currently using Notions' naming convention, **settings**. This results in the newly created view `SettingsSettingsView,` which I'm not sure is a good name. **Notion:** <img width="815" alt="image" src="https://user-images.githubusercontent.com/5762483/177236994-599b4575-f64b-4d69-a47e-c5d3cfc51b6c.png"> **AppFlowy:** <img width="643" alt="image" src="https://user-images.githubusercontent.com/5762483/177236890-157862c8-fe69-46a5-b47e-354e59f348d2.png"> 3. I need to pass `UserProfile user` all the way down into the widget; I hope this is correct. 4. I have not yet implemented the icon section; I will do so later. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>