[PR #599] [MERGED] Refactor/grid decode cell data #4226

New issue

Closed

opened 2026-03-23 21:36:52 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:36:52 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/599
Author: @appflowy
Created: 7/8/2022
Status: ✅ Merged
Merged: 7/8/2022
Merged by: @appflowy

Base: main ← Head: refactor/grid_decode_cell_data

📝 Commits (4)

41989cf chore: add comments
4ec1e40 refactor: cell data parser
5177884 refactor: cell data operation
4577409 chore: separate cell operation from row mod

📊 Changes

26 files changed (+616 additions, -567 deletions)

View changed files

📝 frontend/app_flowy/lib/workspace/application/grid/cell/cell_service/cell_service.dart (+1 -1)
📝 frontend/rust-lib/flowy-grid/src/entities/cell_entities.rs (+2 -2)
📝 frontend/rust-lib/flowy-grid/src/entities/field_entities.rs (+2 -0)
📝 frontend/rust-lib/flowy-grid/src/event_handler.rs (+4 -4)
➕ frontend/rust-lib/flowy-grid/src/services/cell/any_cell_data.rs (+151 -0)
➕ frontend/rust-lib/flowy-grid/src/services/cell/cell_operation.rs (+194 -0)
➕ frontend/rust-lib/flowy-grid/src/services/cell/mod.rs (+5 -0)
📝 frontend/rust-lib/flowy-grid/src/services/field/select_option.rs (+26 -8)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option.rs (+17 -20)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option.rs (+65 -60)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/multi_select_type_option.rs (+25 -28)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_type_option.rs (+16 -18)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/single_select_type_option.rs (+25 -30)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/text_type_option.rs (+30 -25)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/url_type_option.rs (+24 -35)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/util/cell_data_util.rs (+1 -1)
📝 frontend/rust-lib/flowy-grid/src/services/filter/filter_service.rs (+2 -3)
📝 frontend/rust-lib/flowy-grid/src/services/grid_editor.rs (+11 -12)
📝 frontend/rust-lib/flowy-grid/src/services/mod.rs (+1 -0)
➖ frontend/rust-lib/flowy-grid/src/services/row/cell_data_operation.rs (+0 -305)

...and 6 more files

📄 Description

add comments for cell operation
refactor cell operation fn
separate cell_operation.rs from row mod.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/599 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 7/8/2022 **Status:** ✅ Merged **Merged:** 7/8/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `refactor/grid_decode_cell_data` --- ### 📝 Commits (4) - [`41989cf`](https://github.com/AppFlowy-IO/AppFlowy/commit/41989cf1866c0d2c73877b5b6c13aca40a9eecad) chore: add comments - [`4ec1e40`](https://github.com/AppFlowy-IO/AppFlowy/commit/4ec1e4024e2b6ad7bd5b4a506e70a435013eb497) refactor: cell data parser - [`5177884`](https://github.com/AppFlowy-IO/AppFlowy/commit/5177884b26983cb308eddda97dffcd4cc55474f6) refactor: cell data operation - [`4577409`](https://github.com/AppFlowy-IO/AppFlowy/commit/45774093e14407262eac0436d62a9fc58b6708b1) chore: separate cell operation from row mod ### 📊 Changes **26 files changed** (+616 additions, -567 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/workspace/application/grid/cell/cell_service/cell_service.dart` (+1 -1) 📝 `frontend/rust-lib/flowy-grid/src/entities/cell_entities.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-grid/src/entities/field_entities.rs` (+2 -0) 📝 `frontend/rust-lib/flowy-grid/src/event_handler.rs` (+4 -4) ➕ `frontend/rust-lib/flowy-grid/src/services/cell/any_cell_data.rs` (+151 -0) ➕ `frontend/rust-lib/flowy-grid/src/services/cell/cell_operation.rs` (+194 -0) ➕ `frontend/rust-lib/flowy-grid/src/services/cell/mod.rs` (+5 -0) 📝 `frontend/rust-lib/flowy-grid/src/services/field/select_option.rs` (+26 -8) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option.rs` (+17 -20) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option.rs` (+65 -60) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/multi_select_type_option.rs` (+25 -28) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_type_option.rs` (+16 -18) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/single_select_type_option.rs` (+25 -30) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/text_type_option.rs` (+30 -25) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/url_type_option.rs` (+24 -35) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/util/cell_data_util.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-grid/src/services/filter/filter_service.rs` (+2 -3) 📝 `frontend/rust-lib/flowy-grid/src/services/grid_editor.rs` (+11 -12) 📝 `frontend/rust-lib/flowy-grid/src/services/mod.rs` (+1 -0) ➖ `frontend/rust-lib/flowy-grid/src/services/row/cell_data_operation.rs` (+0 -305) _...and 6 more files_ </details> ### 📄 Description 1. add comments for cell operation 2. refactor cell operation fn 3. separate cell_operation.rs from row mod. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>