[PR #844] [MERGED] feat: implement editor test infra #4381

New issue

Closed

opened 2026-03-23 21:37:33 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:37:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/844
Author: @LucasXu0
Created: 8/13/2022
Status: ✅ Merged
Merged: 8/15/2022
Merged by: @LucasXu0

Base: main ← Head: feat/widget_test

📝 Commits (7)

a6bba5a feat: implement editor test infra
e508d74 chore: delete legacy test file
d6f1593 test: implement enter key test for styled text
07ab4c2 test: add flowy_editor_test into github workflows
556aa8c test: add flowy_editor_test into github workflows
b372028 chore: Keep the test directory and code directory structure consistent
c7b0ddf test: enter key handler test coverage 100%

📊 Changes

16 files changed (+465 additions, -24 deletions)

View changed files

📝 .github/workflows/dart_test.yml (+0 -6)
➕ .github/workflows/flowy_editor_test.yml (+36 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/flowy_editor.dart (+1 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/document/node.dart (+21 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/document/state_tree.dart (+12 -1)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/editor_state.dart (+6 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/enter_without_shift_in_text_node_handler.dart (+12 -5)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/service/keyboard_service.dart (+15 -9)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/service/render_plugin_service.dart (+2 -1)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/service/selection_service.dart (+2 -2)
➕ frontend/app_flowy/packages/flowy_editor/test/infra/test_editor.dart (+108 -0)
➕ frontend/app_flowy/packages/flowy_editor/test/infra/test_raw_key_event.dart (+52 -0)
📝 frontend/app_flowy/packages/flowy_editor/test/legacy/delta_test.dart (+0 -0)
📝 frontend/app_flowy/packages/flowy_editor/test/legacy/flowy_editor_test.dart (+0 -0)
📝 frontend/app_flowy/packages/flowy_editor/test/legacy/operation_test.dart (+0 -0)
➕ frontend/app_flowy/packages/flowy_editor/test/service/internal_key_event_handlers/enter_without_shift_in_text_node_handler_test.dart (+198 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/844 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 8/13/2022 **Status:** ✅ Merged **Merged:** 8/15/2022 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/widget_test` --- ### 📝 Commits (7) - [`a6bba5a`](https://github.com/AppFlowy-IO/AppFlowy/commit/a6bba5a0f9b19445b43e0bcd0da229811b3ccdd2) feat: implement editor test infra - [`e508d74`](https://github.com/AppFlowy-IO/AppFlowy/commit/e508d7414c3ca72043a3739cd2d19986d2ad72db) chore: delete legacy test file - [`d6f1593`](https://github.com/AppFlowy-IO/AppFlowy/commit/d6f1593a20b4a5dfbcb758ffc9144ed51b8b4a80) test: implement enter key test for styled text - [`07ab4c2`](https://github.com/AppFlowy-IO/AppFlowy/commit/07ab4c2680efccea83411c318b85edcb487d867d) test: add flowy_editor_test into github workflows - [`556aa8c`](https://github.com/AppFlowy-IO/AppFlowy/commit/556aa8c3df2db40da841a230f85ddc1b5bf435e2) test: add flowy_editor_test into github workflows - [`b372028`](https://github.com/AppFlowy-IO/AppFlowy/commit/b37202867114f5b61c82cb91209befa010d55a1a) chore: Keep the test directory and code directory structure consistent - [`c7b0ddf`](https://github.com/AppFlowy-IO/AppFlowy/commit/c7b0ddfa1dffff91e30450da1d329e9feed73bf8) test: enter key handler test coverage 100% ### 📊 Changes **16 files changed** (+465 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/dart_test.yml` (+0 -6) ➕ `.github/workflows/flowy_editor_test.yml` (+36 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/flowy_editor.dart` (+1 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/document/node.dart` (+21 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/document/state_tree.dart` (+12 -1) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/editor_state.dart` (+6 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/enter_without_shift_in_text_node_handler.dart` (+12 -5) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/service/keyboard_service.dart` (+15 -9) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/service/render_plugin_service.dart` (+2 -1) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/service/selection_service.dart` (+2 -2) ➕ `frontend/app_flowy/packages/flowy_editor/test/infra/test_editor.dart` (+108 -0) ➕ `frontend/app_flowy/packages/flowy_editor/test/infra/test_raw_key_event.dart` (+52 -0) 📝 `frontend/app_flowy/packages/flowy_editor/test/legacy/delta_test.dart` (+0 -0) 📝 `frontend/app_flowy/packages/flowy_editor/test/legacy/flowy_editor_test.dart` (+0 -0) 📝 `frontend/app_flowy/packages/flowy_editor/test/legacy/operation_test.dart` (+0 -0) ➕ `frontend/app_flowy/packages/flowy_editor/test/service/internal_key_event_handlers/enter_without_shift_in_text_node_handler_test.dart` (+198 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>