[PR #4381] [MERGED] fix: fix secondary button outline color #6226

New issue

Closed

opened 2026-03-23 22:22:17 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4381
Author: @hyj1204
Created: 1/12/2024
Status: ✅ Merged
Merged: 1/14/2024
Merged by: @LucasXu0

Base: main ← Head: fix/secondary_button_color

📝 Commits (2)

6e7cf9c chore: restore the default outline color in SecondaryButton
cf22b5d chore: improve outline color for learn more button

📊 Changes

2 files changed (+10 additions, -2 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_learn_more_button.dart (+1 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/buttons/secondary_button.dart (+9 -2)

📄 Description

Feature Preview
Restored the outline color for the secondary button prior to #4317.
Add an outline color field in the secondary button to build the learn more button in the customized theme dialog.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4381 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 1/12/2024 **Status:** ✅ Merged **Merged:** 1/14/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/secondary_button_color` --- ### 📝 Commits (2) - [`6e7cf9c`](https://github.com/AppFlowy-IO/AppFlowy/commit/6e7cf9cf3954f420bf2c43798126717c23acd43a) chore: restore the default outline color in SecondaryButton - [`cf22b5d`](https://github.com/AppFlowy-IO/AppFlowy/commit/cf22b5d00140b9c0d13d424da5f2a347c0213817) chore: improve outline color for learn more button ### 📊 Changes **2 files changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_learn_more_button.dart` (+1 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/buttons/secondary_button.dart` (+9 -2) </details> ### 📄 Description   - ### Feature Preview - Restored the outline color for the secondary button prior to #4317. - Add an outline color field in the secondary button to build the learn more button in the customized theme dialog. <img width="629" alt="Continue with an anonymous session" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/8b77134f-0ec0-469d-97f6-3ff6fc3e2580"> <img width="613" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/1f225808-c019-479b-8b6d-d3c6a000c6a6"> <img width="614" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/3ac6ddee-155a-44de-998e-cd8b9cc24439">  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>