[PR #6455] [MERGED] feat: resume selection on window focus #7393

New issue

Closed

opened 2026-03-23 23:19:24 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6455
Author: @Xazin
Created: 10/3/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @Xazin

Base: main ← Head: feat/resume-selection

📝 Commits (5)

62da9db feat: resume selection on window focus
5d79784 test: use inactive state + pump
61b97d0 fix: add isDisposed check
17b529e fix: isDisposed check in lifecycle
1be303d chore: merge branch 'upstream/main' into feat/resume-selection

📊 Changes

3 files changed (+60 additions, -2 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/desktop/document/document_app_lifecycle_test.dart (+32 -0)
📝 frontend/appflowy_flutter/integration_test/desktop_runner_3.dart (+4 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+24 -1)

📄 Description

Closes: #6226

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6455 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 10/3/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `feat/resume-selection` --- ### 📝 Commits (5) - [`62da9db`](https://github.com/AppFlowy-IO/AppFlowy/commit/62da9db73b9d7a9d205f6b7dde331ce9b02152a4) feat: resume selection on window focus - [`5d79784`](https://github.com/AppFlowy-IO/AppFlowy/commit/5d7978464d6be34bebcdc036bc580345e796188e) test: use inactive state + pump - [`61b97d0`](https://github.com/AppFlowy-IO/AppFlowy/commit/61b97d01de1c1ab7f6cab417eadbe9bc6b7ecb12) fix: add isDisposed check - [`17b529e`](https://github.com/AppFlowy-IO/AppFlowy/commit/17b529eddc708f9803fe1fffe9f1eda71de43e24) fix: isDisposed check in lifecycle - [`1be303d`](https://github.com/AppFlowy-IO/AppFlowy/commit/1be303df607637c4987ca54671fa7bbc7a03cac2) chore: merge branch 'upstream/main' into feat/resume-selection ### 📊 Changes **3 files changed** (+60 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/desktop/document/document_app_lifecycle_test.dart` (+32 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop_runner_3.dart` (+4 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+24 -1) </details> ### 📄 Description Closes: #6226 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>