[PR #976] [CLOSED] Implement Embed code #4469

New issue

Closed

opened 2026-03-23 21:37:57 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:37:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/976
Author: @rileyhawk1417
Created: 9/3/2022
Status: ❌ Closed

Base: main ← Head: embed_code

📝 Commits (10+)

0799bc3 fix: fix linux build
834f720 Merge pull request #599 from AppFlowy-IO/refactor/grid_decode_cell_data
2cc5f94 Merge remote-tracking branch 'upstream/main'
4a6e19e Merge remote-tracking branch 'upstream/main'
51224ad Merge branch 'main' of github.com:rileyhawk1417/appflowy
4ed26ea Merge remote-tracking branch 'upstream/main'
9815382 Merge remote-tracking branch 'upstream/main'
ea69f6e Merge remote-tracking branch 'upstream/main'
023bfe4 Merge remote-tracking branch 'upstream/main'
77cf493 Merge remote-tracking branch 'upstream/main'

📊 Changes

8 files changed (+123 additions, -1 deletions)

View changed files

➕ frontend/app_flowy/packages/appflowy_editor/assets/images/code.svg (+4 -0)
➕ frontend/app_flowy/packages/appflowy_editor/assets/images/selection_menu/code.svg (+4 -0)
➕ frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/embed_code.dart (+75 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/rich_text_style.dart (+4 -1)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_service.dart (+8 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item.dart (+16 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/default_text_operations/format_rich_text_style.dart (+10 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/editor_service.dart (+2 -0)

📄 Description

This PR is meant to solve some of the tasks on issue #911.

What has been done:

Implement the icon in the toolbar.
Should apply style after option has been clicked.
"Embed Code" has been added in "/" menu command.

What's left:

Keyshortcuts.
Wrapping the text in "abc" then applying the style.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/976 **Author:** [@rileyhawk1417](https://github.com/rileyhawk1417) **Created:** 9/3/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `embed_code` --- ### 📝 Commits (10+) - [`0799bc3`](https://github.com/AppFlowy-IO/AppFlowy/commit/0799bc3556110548ddf0dcc799cb50d37754853a) fix: fix linux build - [`834f720`](https://github.com/AppFlowy-IO/AppFlowy/commit/834f7208b5379a368fd300db6fcb9d0bd8b3025b) Merge pull request #599 from AppFlowy-IO/refactor/grid_decode_cell_data - [`2cc5f94`](https://github.com/AppFlowy-IO/AppFlowy/commit/2cc5f9407e192cc920ac88e74eda8369a33081ce) Merge remote-tracking branch 'upstream/main' - [`4a6e19e`](https://github.com/AppFlowy-IO/AppFlowy/commit/4a6e19ea908abe1da8ccc0aeb963d0410c9dee6f) Merge remote-tracking branch 'upstream/main' - [`51224ad`](https://github.com/AppFlowy-IO/AppFlowy/commit/51224adca56f041839e39a33cf1cd5c50954f077) Merge branch 'main' of github.com:rileyhawk1417/appflowy - [`4ed26ea`](https://github.com/AppFlowy-IO/AppFlowy/commit/4ed26ea5a95b5f16093951343a60004e9a4ce004) Merge remote-tracking branch 'upstream/main' - [`9815382`](https://github.com/AppFlowy-IO/AppFlowy/commit/98153825f202370316bd633bcb2654d89956cec3) Merge remote-tracking branch 'upstream/main' - [`ea69f6e`](https://github.com/AppFlowy-IO/AppFlowy/commit/ea69f6e313466a4a5b57d116d5778d26d28a3772) Merge remote-tracking branch 'upstream/main' - [`023bfe4`](https://github.com/AppFlowy-IO/AppFlowy/commit/023bfe4677ed80e8669806f87091907d910ec314) Merge remote-tracking branch 'upstream/main' - [`77cf493`](https://github.com/AppFlowy-IO/AppFlowy/commit/77cf4934e066e06d7f9c2646e4ef295fd3a992cd) Merge remote-tracking branch 'upstream/main' ### 📊 Changes **8 files changed** (+123 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `frontend/app_flowy/packages/appflowy_editor/assets/images/code.svg` (+4 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/assets/images/selection_menu/code.svg` (+4 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/embed_code.dart` (+75 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/rich_text_style.dart` (+4 -1) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_service.dart` (+8 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item.dart` (+16 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/default_text_operations/format_rich_text_style.dart` (+10 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/editor_service.dart` (+2 -0) </details> ### 📄 Description This PR is meant to solve some of the tasks on issue #911. ### What has been done: - [x] Implement the icon in the toolbar. - [x] Should apply style after option has been clicked. - [x] "Embed Code" has been added in "/" menu command. ### What's left: - [ ] Keyshortcuts. - [ ] Wrapping the text in "``abc``" then applying the style. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>