[PR #1085] [MERGED] Fix/popover bugs #4522

Closed
opened 2026-03-23 21:38:11 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1085
Author: @appflowy
Created: 9/18/2022
Status: Merged
Merged: 9/18/2022
Merged by: @appflowy

Base: mainHead: fix/popover_bugs


📝 Commits (4)

  • 3a1148d refactor: add documentation to card.dart
  • 6c27b54 refactor: replace FlowyOverlay with AppFlowyPopover in select option
  • c493ba7 chore: unfocus the textField after switching to another popover
  • bda16b1 chore: replace Popover with Appflowy style popover and fix some bugs

📊 Changes

20 files changed (+404 additions, -380 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/board/presentation/card/board_cell.dart (+2 -2)
📝 frontend/app_flowy/lib/plugins/board/presentation/card/board_number_cell.dart (+0 -1)
📝 frontend/app_flowy/lib/plugins/board/presentation/card/board_select_option_cell.dart (+56 -35)
📝 frontend/app_flowy/lib/plugins/board/presentation/card/card.dart (+61 -42)
📝 frontend/app_flowy/lib/plugins/board/presentation/card/card_container.dart (+28 -34)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_cell.dart (+53 -55)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart (+3 -45)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell.dart (+3 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell_action_sheet.dart (+30 -30)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_editor.dart (+108 -30)
frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_name_input.dart (+0 -56)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_type_list.dart (+0 -4)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_type_option_editor.dart (+2 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/builder.dart (+3 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/date.dart (+10 -22)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/number.dart (+1 -7)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart (+2 -2)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/toolbar/grid_property.dart (+4 -2)
📝 frontend/app_flowy/lib/workspace/presentation/widgets/dialogs.dart (+0 -3)
📝 frontend/app_flowy/packages/appflowy_popover/lib/popover.dart (+38 -7)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1085 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 9/18/2022 **Status:** ✅ Merged **Merged:** 9/18/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/popover_bugs` --- ### 📝 Commits (4) - [`3a1148d`](https://github.com/AppFlowy-IO/AppFlowy/commit/3a1148d11adf6c76c3e6d67d7a9e28c4d5bdc673) refactor: add documentation to card.dart - [`6c27b54`](https://github.com/AppFlowy-IO/AppFlowy/commit/6c27b5455ea6b4fe2b2bbce8cc8809f488595132) refactor: replace FlowyOverlay with AppFlowyPopover in select option - [`c493ba7`](https://github.com/AppFlowy-IO/AppFlowy/commit/c493ba79e021759e24699bedbdab0a688ad7264f) chore: unfocus the textField after switching to another popover - [`bda16b1`](https://github.com/AppFlowy-IO/AppFlowy/commit/bda16b136b396a121e4eb94f179be57684e69825) chore: replace Popover with Appflowy style popover and fix some bugs ### 📊 Changes **20 files changed** (+404 additions, -380 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/board/presentation/card/board_cell.dart` (+2 -2) 📝 `frontend/app_flowy/lib/plugins/board/presentation/card/board_number_cell.dart` (+0 -1) 📝 `frontend/app_flowy/lib/plugins/board/presentation/card/board_select_option_cell.dart` (+56 -35) 📝 `frontend/app_flowy/lib/plugins/board/presentation/card/card.dart` (+61 -42) 📝 `frontend/app_flowy/lib/plugins/board/presentation/card/card_container.dart` (+28 -34) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_cell.dart` (+53 -55) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart` (+3 -45) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell.dart` (+3 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell_action_sheet.dart` (+30 -30) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_editor.dart` (+108 -30) ➖ `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_name_input.dart` (+0 -56) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_type_list.dart` (+0 -4) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_type_option_editor.dart` (+2 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/builder.dart` (+3 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/date.dart` (+10 -22) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/number.dart` (+1 -7) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart` (+2 -2) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/toolbar/grid_property.dart` (+4 -2) 📝 `frontend/app_flowy/lib/workspace/presentation/widgets/dialogs.dart` (+0 -3) 📝 `frontend/app_flowy/packages/appflowy_popover/lib/popover.dart` (+38 -7) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 21:38:11 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#4522
No description provided.