[PR #4522] [MERGED] feat: f2 to rename current view #6290

New issue

Closed

opened 2026-03-23 22:22:34 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4522
Author: @Xazin
Created: 1/27/2024
Status: ✅ Merged
Merged: 1/29/2024
Merged by: @Xazin

Base: main ← Head: feat/support-hotkey-rename-current-view

📝 Commits (4)

1d25b07 feat: cmd+shift+r to rename current view
2501b72 test: change cmd to f2 and add test
195b11c chore: code review
7a092de fix: unawaited future

📊 Changes

8 files changed (+247 additions, -62 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/sidebar/rename_current_item_test.dart (+51 -0)
📝 frontend/appflowy_flutter/lib/startup/deps_resolver.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart (+5 -2)
➕ frontend/appflowy_flutter/lib/workspace/application/sidebar/rename_view/rename_view_bloc.dart (+37 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart (+16 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+31 -7)
➕ frontend/appflowy_flutter/lib/workspace/presentation/widgets/rename_view_popover.dart (+93 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart (+10 -51)

📄 Description

Closes: #3490

Feature Preview

Using CMD+SHIFT+R to quickly rename current page.

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/01b9dafe-6a81-4259-88f8-6a4964a81aad

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Focus is not returned to the Editor after renaming, possible future improvement.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4522 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 1/27/2024 **Status:** ✅ Merged **Merged:** 1/29/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `feat/support-hotkey-rename-current-view` --- ### 📝 Commits (4) - [`1d25b07`](https://github.com/AppFlowy-IO/AppFlowy/commit/1d25b07b9eb629624e45e27216d546ab2f46cf8f) feat: cmd+shift+r to rename current view - [`2501b72`](https://github.com/AppFlowy-IO/AppFlowy/commit/2501b72464a08d48f7ab0758b56b66aef54798fd) test: change cmd to f2 and add test - [`195b11c`](https://github.com/AppFlowy-IO/AppFlowy/commit/195b11c8e549470f0a784759fcf22bfb593bc810) chore: code review - [`7a092de`](https://github.com/AppFlowy-IO/AppFlowy/commit/7a092de0db5bcf3dac18307b6a43903a74e33012) fix: unawaited future ### 📊 Changes **8 files changed** (+247 additions, -62 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/sidebar/rename_current_item_test.dart` (+51 -0) 📝 `frontend/appflowy_flutter/lib/startup/deps_resolver.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart` (+5 -2) ➕ `frontend/appflowy_flutter/lib/workspace/application/sidebar/rename_view/rename_view_bloc.dart` (+37 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart` (+16 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+31 -7) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/widgets/rename_view_popover.dart` (+93 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart` (+10 -51) </details> ### 📄 Description Closes: #3490 ### Feature Preview Using `CMD+SHIFT+R` to quickly rename current page. https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/01b9dafe-6a81-4259-88f8-6a4964a81aad #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- Focus is not returned to the Editor after renaming, possible future improvement. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>