[PR #1224] [MERGED] fix: improve look of share button dropdown menu #4604

New issue

Closed

opened 2026-03-23 21:38:32 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1224
Author: @richardshiue
Created: 10/4/2022
Status: ✅ Merged
Merged: 10/6/2022
Merged by: @appflowy

Base: main ← Head: improv-share-menu

📝 Commits (1)

4cd4d88 fix: improve look of share button dropdown menu

📊 Changes

2 files changed (+7 additions, -9 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/doc/document.dart (+6 -6)
📝 frontend/app_flowy/lib/workspace/presentation/widgets/pop_up_action.dart (+1 -3)

📄 Description

This patch does three things: 1. remove the padding between the icon and the text if there is no icon, 2. align the content of each row at the center along the crossaxis, and 3. align the dropdown menu with the right edge of the share button. The extra spacing to the right is not fixed yet and is tracked at #1206. Oh and changed the color of the button too!

Before:

After:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1224 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/4/2022 **Status:** ✅ Merged **Merged:** 10/6/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `improv-share-menu` --- ### 📝 Commits (1) - [`4cd4d88`](https://github.com/AppFlowy-IO/AppFlowy/commit/4cd4d88c8e4a39016a43b578717cb80b2e6fb759) fix: improve look of share button dropdown menu ### 📊 Changes **2 files changed** (+7 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/doc/document.dart` (+6 -6) 📝 `frontend/app_flowy/lib/workspace/presentation/widgets/pop_up_action.dart` (+1 -3) </details> ### 📄 Description This patch does three things: 1. remove the padding between the icon and the text if there is no icon, 2. align the content of each row at the center along the crossaxis, and 3. align the dropdown menu with the right edge of the share button. The extra spacing to the right is not fixed yet and is tracked at #1206. Oh and changed the color of the button too! Before: ![image](https://user-images.githubusercontent.com/71320345/193846282-6360806d-77ff-47ce-be17-cf92881fe71e.png) After: ![image](https://user-images.githubusercontent.com/71320345/193846960-857a48fe-09f3-4318-9696-3d34d19a255f.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>